Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard shortcuts to increase and decrease font size (or zoom) #1708

Closed
wizll opened this issue Jun 28, 2019 · 9 comments · Fixed by #2700
Closed

Add keyboard shortcuts to increase and decrease font size (or zoom) #1708

wizll opened this issue Jun 28, 2019 · 9 comments · Fixed by #2700
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@wizll
Copy link

wizll commented Jun 28, 2019

It would be nice to quickly increase the size of my font (similar to zooming in a web browser). (ctrl)+(+) and (ctrl)+(-)
@wizll wizll added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 28, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 28, 2019
@jefflomax
Copy link

CTRL Mouse Up/Down works and is consistent with existing shell

@dnagl
Copy link
Contributor

dnagl commented Jun 30, 2019

@wizll I will take a attemt to solve this feature request

@dnagl dnagl mentioned this issue Jun 30, 2019
Closed
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Jun 30, 2019
@dnagl
Copy link
Contributor

dnagl commented Jun 30, 2019

I've done a implementation for this feature request.
Waiting for code-review and merge :)

@DHowett-MSFT
Copy link
Contributor

Since you've put out a pull request for this, I'm going to mark it as triaged and accept it for v1.0 😄

@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Jul 2, 2019
@DHowett-MSFT DHowett-MSFT added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 2, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 2, 2019
@DHowett-MSFT DHowett-MSFT changed the title Feature Request - keyboard shortcut to increase and decrease font size (or zoom) Add keyboard shortcuts to increase and decrease font size (or zoom) Jul 2, 2019
@ghost ghost removed the In-PR This issue has a related PR label Jul 19, 2019
@hwinkler
Copy link

The above PR seems to have died and never been accepted. Just want to register my interest in this feature. A key combination (as in VS Code and many other examples) Ctrl plus/minus is essential because the existing Ctrl+ scroll support is awkward on a touchpad. A terminal program ought not assume the presence of any pointing or scrolling device. It's a terminal.

I hope the team will complete this effort.

@vallamost
Copy link

I am surprised that this hasn't been implemented yet, hopefully the CR can be revived / finalized.

@dsafa
Copy link
Contributor

dsafa commented Sep 5, 2019

I'm interested in seeing this feature done. I can try and continue where the PR left off if thats ok.

@zadjii-msft
Copy link
Member

@dsafa Go for it!

@dsafa dsafa mentioned this issue Sep 9, 2019
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Sep 9, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR labels Sep 30, 2019
@ghost
Copy link

ghost commented Oct 23, 2019

🎉This issue was addressed in #2700, which has now been successfully released as Windows Terminal Preview v0.6.2951.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
8 participants
@hwinkler @wizll @jefflomax @dsafa @DHowett-MSFT @zadjii-msft @dnagl @vallamost