Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the background colour per tab #1729

Closed
dfoulkes opened this issue Jun 30, 2019 · 12 comments
Closed

Change the background colour per tab #1729

dfoulkes opened this issue Jun 30, 2019 · 12 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@dfoulkes
Copy link

Summary of the new feature/enhancement

Allow the user to choose a colour for the tab

Proposed technical implementation details (optional)

customise the colour of the tabs by right clicking on the tab --> settings --> choose colour

BDD Stories

SCENARIO: user opens a new tab
GIVEN: has opened a new terminal
WHEN user right clicks the tab
THEN they are supplied with a settings option

SCENARIO: user wishes to change the colour of a tab
GIVEN: user is in the settings menu
WHEN wanting to change the colour of a tab
THEN user is presented with the current colour, and a colour wheel to choose from

SCENARIO: user selects a new colour
GIVEN: user has selected a new colour
WHEN user clicks OK
THEN the tab is set to the colour selected.

SCENARIO: user selects a new colour
GIVEN: user has selected a new colour
WHEN user clicks Cancel
THEN the tab remains the same colour as it did prior

@dfoulkes dfoulkes added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 30, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 30, 2019
@JushBJJ
Copy link

JushBJJ commented Jun 30, 2019

This seems like a original idea, I like it

@DHowett-MSFT
Copy link
Contributor

FWIW a connected text-mode application can set the Terminal’s background color with OSC 11: \e]11;rgb:ff/ff/ff\e\\

@dfoulkes
Copy link
Author

dfoulkes commented Jul 1, 2019

I hope by colour coding the tabs without changing the terminal colour also. The idea is to supply visual cues to help manage multiple tabs simultaneously.

@andrestest1125
Copy link

Yes please, VSCODE it's great already, you can make it similar

@dfoulkes
Copy link
Author

dfoulkes commented Jul 1, 2019

I wonder, should this also include the ability to rename the tab ? I suppose that would be another ticket.

@DHowett-MSFT
Copy link
Contributor

For color coding tabs we've got #1337 (nice number). I'm not opposed to this, but I'd like to understand whether OSC 11 works for this scenario. If it does, we can drop it back in the order to line up with #1564 and other UI things.

@DHowett-MSFT DHowett-MSFT added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 2, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone Jul 2, 2019
@DHowett-MSFT DHowett-MSFT added the Product-Terminal The new Windows Terminal. label Jul 2, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 2, 2019
@ghost
Copy link

ghost commented Jul 6, 2019

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Jul 6, 2019
@dfoulkes
Copy link
Author

dfoulkes commented Jul 6, 2019

I would argue that #1337 is more about having a Permanent tab colour for a profile, my suggestion is that to help facilitate someone that’s let’s say has many PowerShell tabs open, to change its colour to help index them whilst working.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. labels Jul 6, 2019
@dfoulkes
Copy link
Author

dfoulkes commented Jul 6, 2019

Can anyone validate is OSC11 would work in the way this story describes ?

@zadjii-msft
Copy link
Member

@dfoulkes just to help clarify, do you want to set the background color of the tab
image

or the background color of the buffer
image

at runtime? OSC 11 will work for the buffer:
image
but there's not a way to change the color of the tab at runtime.

@dfoulkes
Copy link
Author

dfoulkes commented Jul 9, 2019

@zadjii-msft the story was aimed at the tab.

@DHowett-MSFT
Copy link
Contributor

Whoops, sorry about that. My bad. In that case, this is #1337 😄

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jul 9, 2019
@DHowett-MSFT DHowett-MSFT added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Jul 9, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 9, 2019
@zadjii-msft zadjii-msft removed this from the Terminal Backlog milestone Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

5 participants