Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying with Ctrl-Shift-C copies literal buffer, not lines #174

Open
parkovski opened this issue May 10, 2018 · 6 comments
Open

Copying with Ctrl-Shift-C copies literal buffer, not lines #174

parkovski opened this issue May 10, 2018 · 6 comments
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase Work-Item It's being tracked by an actual work item internally. (to be removed soon)
Milestone

Comments

@parkovski
Copy link

parkovski commented May 10, 2018

Selecting text and copying with Ctrl-Shift-C copies the buffer literally, which gives a line full of spaces and no newline. Copying with right click works as intended. Verified in cmd.exe, pwsh.exe and zsh.

  • Your Windows build number: (Type ver at a Windows Command Prompt)
    17666

  • What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots)

PS> echo "foo`nbar"
foo
bar
PS> # copy those two lines with Ctrl-Shift-C and paste into notepad
PS> # should have a line full of spaces before "bar"
  • What's wrong / what should be happening instead:
    It should do the same thing as right click copy - lines have a new line at the end instead of being filled with spaces.
@MichaelTong
Copy link

This still happens on 17713.

@tombrown52
Copy link

This still happens on 1809 (17763).

It seems to me that copy and paste should behave the same, whether done via the mouse (right-click) or keyboard (ctrl+shift+c/v).

As it is, all the extra spaces and lack of newlines makes the keyboard shortcut ctrl+shift+c useless for all but the most simple selections.

@miniksa miniksa added Product-Conhost For issues in the Console codebase Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Work-Item It's being tracked by an actual work item internally. (to be removed soon) labels Jan 22, 2019
@miniksa
Copy link
Member

miniksa commented Jan 22, 2019

I've filed MSFT: 20265934 to look into this.

@zadjii-msft
Copy link
Member

Actually this one might be by design. IIRC, Ctrl-Shift-C always had this behavior, and it always worked, even w/o the "copy/paste with Ctrl-Shift-C/V" checkbox.

Either we should change the text to just say "Paste with Ctrl-Shift-V", or override the usual copy behavior (copy literally) when that box is checked and replace it with the default copy behavior

@miniksa
Copy link
Member

miniksa commented Jan 22, 2019

The latter is what I'm thinking and why I filed 20265934, @zadjii-msft.

@miniksa miniksa self-assigned this May 14, 2019
@miniksa
Copy link
Member

miniksa commented May 14, 2019

Moving back to tracking the work here. Here's the comments from the internal issue for whenever I get back to it:

I think what's happening here is that the copy feature already had a VK_SHIFT alternate behavior and that's getting caught up in the new Ctrl+Shift+C feature to enable WSL copying.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added Issue-Task It's a feature request, but it doesn't really need a major design. and removed Mass-Chaos labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 18, 2019
@carlos-zamora carlos-zamora added this to the Console Backlog milestone Dec 2, 2019
@zadjii-msft zadjii-msft modified the milestones: Console Backlog, Backlog Jan 4, 2022
@miniksa miniksa removed their assignment Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase Work-Item It's being tracked by an actual work item internally. (to be removed soon)
Projects
None yet
Development

No branches or pull requests

6 participants