Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.23] PatternTree crash after closing two panes in oen tab #18049

Open
DHowett opened this issue Oct 14, 2024 · 3 comments
Open

[1.23] PatternTree crash after closing two panes in oen tab #18049

DHowett opened this issue Oct 14, 2024 · 3 comments
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news.

Comments

@DHowett
Copy link
Member

DHowett commented Oct 14, 2024

Windows Terminal version

Canary 2851

Windows build number

No response

Other Software

No response

Steps to reproduce

Dunno - closed two shells inside panes in the same tab with ^D

Expected Behavior

No response

Actual Behavior

 	Microsoft.Terminal.Control.dll!Microsoft::Console::Render::Renderer::TriggerRedraw(const Microsoft::Console::Types::Viewport & region) Line 262	C++
 	Microsoft.Terminal.Control.dll!Microsoft::Terminal::Core::Terminal::_InvalidateFromCoords(const til::point start, const til::point end) Line 808	C++
 	[Inline Frame] Microsoft.Terminal.Control.dll!Microsoft::Terminal::Core::Terminal::_InvalidatePatternTree::__l2::<lambda_1>::operator()(const interval_tree::Interval<til::point,unsigned __int64> &) Line 774	C++
>	[Inline Frame] Microsoft.Terminal.Control.dll!std::for_each(std::_Vector_const_iterator<std::_Vector_val<std::_Simple_types<interval_tree::Interval<til::point,unsigned __int64>>>>) Line 435	C++
 	Microsoft.Terminal.Control.dll!interval_tree::IntervalTree<til::point,unsigned __int64>::visit_all<`Microsoft::Terminal::Core::Terminal::_InvalidatePatternTree'::`2'::<lambda_1>>(Microsoft::Terminal::Core::Terminal::_InvalidatePatternTree::__l2::<lambda_1> f) Line 308	C++
 	[Inline Frame] Microsoft.Terminal.Control.dll!Microsoft::Terminal::Core::Terminal::_InvalidatePatternTree() Line 771	C++
 	Microsoft.Terminal.Control.dll!Microsoft::Terminal::Core::Terminal::UpdatePatternsUnderLock() Line 1192	C++
 	Microsoft.Terminal.Control.dll!winrt::Microsoft::Terminal::Control::implementation::ControlCore::_setupDispatcherAndCallbacks::__l2::<lambda_1>::operator()() Line 200	C++
 	[Inline Frame] Microsoft.Terminal.Control.dll!std::_Func_class<void>::operator()() Line 920	C++
 	[Inline Frame] Microsoft.Terminal.Control.dll!std::invoke(std::function<void __cdecl(void)> &) Line 1704	C++
 	[Inline Frame] Microsoft.Terminal.Control.dll!std::_Apply_impl(std::function<void __cdecl(void)> &) Line 1076	C++
 	[Inline Frame] Microsoft.Terminal.Control.dll!std::apply(std::function<void __cdecl(void)> &) Line 1087	C++
 	[Inline Frame] Microsoft.Terminal.Control.dll!til::throttled_func<1,0>::_trailing_edge() Line 196	C++
 	Microsoft.Terminal.Control.dll!til::throttled_func<1,0>::_timer_callback(_TP_CALLBACK_INSTANCE * __formal, void * context, _TP_TIMER * __formal) Line 184	C++
@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Severity-Crash Crashes are real bad news. labels Oct 14, 2024
@DHowett
Copy link
Member Author

DHowett commented Oct 14, 2024

in TriggerRedraw

Unhandled exception thrown: read access violation.
pEngine was 0x19EC0EDBB5A.

@lhecker
Copy link
Member

lhecker commented Oct 14, 2024

Meh.

@carlos-zamora carlos-zamora added this to the Terminal v1.23 milestone Oct 16, 2024
@carlos-zamora carlos-zamora added Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 16, 2024
@carlos-zamora
Copy link
Member

Leonard had some ideas on what could be happening. We should probably kill the timer before killing the renderer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news.
Projects
None yet
Development

No branches or pull requests

3 participants