Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close button looks wrong on Accent Title Bar #18226

Closed
DHowett opened this issue Nov 20, 2024 · 2 comments · Fixed by #18306
Closed

Close button looks wrong on Accent Title Bar #18226

DHowett opened this issue Nov 20, 2024 · 2 comments · Fixed by #18306
Assignees
@carlos-zamora
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.23

Comments

@DHowett
Copy link
Member

DHowett commented Nov 20, 2024 •
edited
Loading

@carlos-zamora this is probably related to your changes for HC

image
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 20, 2024
@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 20, 2024
@carlos-zamora carlos-zamora self-assigned this Nov 20, 2024
@carlos-zamora carlos-zamora added this to the Terminal v1.23 milestone Nov 20, 2024
@carlos-zamora
Copy link
Member

@DHowett mind sharing your settings? I'll be sure to fix this as a part of #18306 (if it isn't already fixed there).

@DHowett
Copy link
Member Author

DHowett commented Dec 11, 2024

A-ha!

It only triggers when the tab background is also set to terminalBackground.

    "theme": "Accent Tb",
    "themes": 
    [
        {
            "name": "Accent Tb",
            "tab": { "background": "terminalBackground" },
            "tabRow": { "background": "accent" }
        }
    ]

@carlos-zamora carlos-zamora mentioned this issue Dec 11, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Dec 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.23
Development

Successfully merging a pull request may close this issue.

Fix colored tab losing color when unselected microsoft/terminal
2 participants
@DHowett @carlos-zamora