Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New window instances do not gain foreground rights #18324

Closed
lhecker opened this issue Dec 13, 2024 · 2 comments · Fixed by #18325
Closed

New window instances do not gain foreground rights #18324

lhecker opened this issue Dec 13, 2024 · 2 comments · Fixed by #18325
Assignees
@lhecker
Labels
Area-Windowing Window frame, quake mode, tearout In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.

Comments

@lhecker
Copy link
Member

lhecker commented Dec 13, 2024

Windows Terminal version

1.23.3471.0

Windows build number

No response

Other Software

No response

Steps to reproduce

  • Set "New instance behavior" to "Create a new window"
  • Launch from the start menu (= first window, first tab)
  • Explicitly minimize
  • Launch from the start menu again

Expected Behavior

New window is in the foreground.

Actual Behavior

New window fails to gain foreground rights.
@lhecker lhecker added Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels Dec 13, 2024
@lhecker lhecker self-assigned this Dec 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 13, 2024
@zadjii-msft
Copy link
Member

Can we AllowSetForeground? I suppose we don't know the PID of the instance holding the mutex, do we. hmm....

@zadjii-msft zadjii-msft added the Severity-Blocking We won't ship a release like this! No-siree. label Dec 13, 2024
@lhecker lhecker mentioned this issue Dec 13, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Dec 13, 2024
@lhecker
Copy link
Member Author

lhecker commented Dec 13, 2024

Oh, I didn't see your message! And yeah, I fixed it exactly like that. We can get the PID with GetWindowThreadProcessId.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhecker lhecker

Labels
Area-Windowing Window frame, quake mode, tearout In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass foreground rights to the emperor microsoft/terminal
2 participants
@lhecker @zadjii-msft