Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening multiple tabs from a single profile on start, with the default terminal, and on individual profiles. #3037

Closed
danielkeery opened this issue Oct 3, 2019 · 3 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@danielkeery
Copy link

Description of the new feature/enhancement

This FR would solve having to manually setup my workspace on every new launch. I always start with the same 3 tabs, it would be nice to launch these all in the default.

"globals": {
"defaultProfile": ["GUID1", "GUID2", "MULTI-PROFILE-GUID1", ...]
}
...
"profiles": [
{
"guid": "multi-profile guid",
"launchProfiles": ["other profile guid1", "other profile guid 2", ...]
}
]

Proposed technical implementation details (optional)

Change existing launch code into a for loop and the defaultProfile backing as a array.
Either new profile type could be introduced or the detection of launchProfiles for each profile configuration would signal needing to launch other profiles. Recursive?
Support the launching of multiple profiles in any launch action. Should be self explanitory.

@danielkeery danielkeery added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 3, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 3, 2019
@zadjii-msft
Copy link
Member

So I suppose this was discussed before in #1043, though there doesn't seem like there's a unique issue for it, so congratulations, this is now the thread :)

There are probably a bunch of things we'd want to consider as part of a comprehensive solution here.

  • What if someone wants to open the terminal with multiple tabs (what you've already discussed above)
  • What about with multiple panes, in various different split configurations? How would we set that?
  • Perhaps the user wants to auto-launch multiple windows? In different locations, etc.
  • Obviously, any solution for the above three should not preclude any of the others. Users would want to be able to specify multiple windows, each with their own tabs, and with tabs that might have any number of panes.
  • Would we want this multi-launch behavior to only happen on first launch, or every Terminal launch?
  • With the nesting behavior you have above, what if someone had a recursive loop, where one profile A specified launching profile B, and B specified launching A? That would theoretically cause an infinite loop - do we allow that?
  • (I'm sure there's more I'm missing here)

This is certainly a problem that's feasible from an engineering standpoint, but due to the complexity of specifying these scenarios, I'd want a spec written first to try and think through the edge cases before we start working on the code.

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Product-Terminal The new Windows Terminal. labels Oct 3, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Oct 3, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 3, 2019
@DHowett-MSFT
Copy link
Contributor

I'm actually gonna merge this one back into /dup #756, since I found the original "multiple tabs on startup (and more)" issue.

@ghost
Copy link

ghost commented Oct 7, 2019

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Oct 7, 2019
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 7, 2019
@zadjii-msft zadjii-msft removed this from the Terminal Backlog milestone Jan 19, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants