Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a setting to manually set the Pane border width #3063

Open
zadjii-msft opened this issue Oct 4, 2019 · 2 comments
Open

Add a setting to manually set the Pane border width #3063

zadjii-msft opened this issue Oct 4, 2019 · 2 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@zadjii-msft
Copy link
Member

Follow up from #994 and PR:#3060

In the aforementioned PR, we're hardcoding the border width to 2. This should really be configurable to any positive double.

Questions:

  • (Similar to the discussion in Add a setting to manually set the Pane highlight color #3061) There's been discussion before about allowing custom theming, hypothetically powered by XAML. Would we want to wait for that discussion to be had before we do this?
    • If we do want to do this in XAML later, would enabling it in the json now negatively impact that future scenario?
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Oct 4, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Oct 4, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 4, 2019
@zadjii-msft zadjii-msft mentioned this issue Oct 4, 2019
Open
59 tasks
@DHowett-MSFT
Copy link
Contributor

Does this one need to be a setting? Can we live with "there is a border" / "there is no border"?

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 23, 2019
@zadjii-msft
Copy link
Member Author

I mean, there's pretty minimal difference between implementing this as a bool vs a double, right? I personally think a smaller border is nice, but there might be someone who's crazy and wants an 8px border or something

@zadjii-msft zadjii-msft mentioned this issue Nov 8, 2019
Merged
9 tasks
@DHowett DHowett mentioned this issue Nov 26, 2020
Closed
@zadjii-msft zadjii-msft mentioned this issue Jan 11, 2021
Closed
@zadjii-msft zadjii-msft mentioned this issue Aug 18, 2021
Closed
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@zadjii-msft zadjii-msft mentioned this issue Apr 28, 2022
Open
27 tasks
@zadjii-msft zadjii-msft moved this to Should be written in Terminal Walkthroughs Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
Terminal Walkthroughs
Status: Should be written
Milestone
Backlog
Development

No branches or pull requests
2 participants
@DHowett-MSFT @zadjii-msft