Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text font looks little bold in comparison to conhost #3388

Closed
zadjii-msft opened this issue Oct 31, 2019 · 5 comments
Closed

Text font looks little bold in comparison to conhost #3388

zadjii-msft opened this issue Oct 31, 2019 · 5 comments
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Question For questions or discussion Needs-Attention The core contributors need to come back around and look at this ASAP. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@zadjii-msft
Copy link
Member

From @srv-code in #3386:

Text font looks little bold (a difference noticed in comparison to cmd font even after keeping the same font properties).

@srv-code Could you maybe see some screenshots of the difference you're seeing? I'm sure there are going to be slight differences between GDI (the conhost renderer) and DX (the Terminal renderer), but they shouldn't be that significant.

Maybe this has to do with how we're antialiasing? #1298 has some discussion there.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 31, 2019
@zadjii-msft zadjii-msft mentioned this issue Oct 31, 2019
Closed
@zadjii-msft zadjii-msft added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. labels Oct 31, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 31, 2019
@DHowett-MSFT DHowett-MSFT added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Oct 31, 2019
@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Nov 4, 2019
@ghost
Copy link

ghost commented Nov 4, 2019

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@srv-code
Copy link

srv-code commented Nov 5, 2019 •
edited
Loading

From @srv-code in #3386:

Text font looks little bold (a difference noticed in comparison to cmd font even after keeping the same font properties).

@srv-code Could you maybe see some screenshots of the difference you're seeing? I'm sure there are going to be slight differences between GDI (the conhost renderer) and DX (the Terminal renderer), but they shouldn't be that significant.

Maybe this has to do with how we're antialiasing? #1298 has some discussion there.

Yeah. I also think its because of the use of different renderers. The difference is not that significant though. Just that the text in conhost looked much lighter and therefore better if you ask me. Attached is the screenshot from my system (I don't know if you can see the differences in this picture).
diff - fonts of conhost wt

@ghost ghost removed the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Nov 5, 2019
@zadjii-msft
Copy link
Member Author

Looking at that screenshot, it does look like the difference you're referring to does have to do with the way we're anti-aliasing the text. @miniksa can correct me if I'm wrong here. I know we had a lot of discussion about how we anti-alias fonts prior to announcement. I think once we add #1298, you should be able to configure the terminal to at least be closer.

Thanks!

/dup #1298

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 6, 2019
@ghost
Copy link

ghost commented Nov 6, 2019

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 6, 2019
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 6, 2019
@miniksa
Copy link
Member

miniksa commented Nov 6, 2019

Yes, this is just the visual difference between GDI text and DirectWrite text. We're planning on adding more knobs to configure it as @zadjii-msft said.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Question For questions or discussion Needs-Attention The core contributors need to come back around and look at this ASAP. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DHowett-MSFT @miniksa @zadjii-msft @srv-code