Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching on-off property 'Use Legacy Console' does not return terminal to original state. #3430

Closed
wpqs opened this issue Nov 4, 2019 · 2 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@wpqs
Copy link

wpqs commented Nov 4, 2019

Environment

https://github.com/microsoft/terminal/issues

Steps to reproduce

  1. Open Command Prompt - i.e. run cmd
  2. Open Properties | Options - remove check from 'Use Legacy console' - switch OFF
  3. Close Command Prompt
  4. Open Command Prompt - i.e. run cmd
  5. Open Properties | Options - add check from 'Use Legacy console' - switch ON
  6. Close Command Prompt
  7. Open Command Prompt - i.e. run cmd

Expected behavior

All properties of the terminal should be the same as before step 2. That is to say restoring the 'Use Legacy console' property in step 5 should restore the state of the terminal to what it was before the property was changed.

Actual behavior

After restoring the 'Use Legacy console' to OFF the terminal window is blank because the terminal colours have not been correctly restored to their previous state - both foreground and background are black. Similarly the cursor color is black rather than inverse colour.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 4, 2019
@zadjii-msft
Copy link
Member

Hey so I think the bug you're describing is actually a couple things, both in more detail here: #2956. They're #2319, fixed by #2651, and also #2855 makes this scenario better as well.

These should all be arriving with the next feature update of Windows :)

/dup #2319

@ghost
Copy link

ghost commented Nov 4, 2019

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 4, 2019
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 4, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants
@zadjii-msft @wpqs and others