Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danish keyboard layout Ctrl+Alt+7 #4279

Closed
Agazoth opened this issue Jan 17, 2020 · 4 comments
Closed

Danish keyboard layout Ctrl+Alt+7 #4279

Agazoth opened this issue Jan 17, 2020 · 4 comments
Labels
Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity.

Comments

@Agazoth
Copy link

Agazoth commented Jan 17, 2020

Environment

Windows 10, PowerShell 7.0 rc2, PowerShell Core, Windows Powershell
Danish keyboard settings

Steps to reproduce

Ctrl+Alt+7

Expected behavior

I would expect to get
{
in the console

Actual behavior

PowerShellCore and Windows PowerShell:
^_

PowerShell 7.0 rc1 and rc2
_

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 17, 2020
@DHowett-MSFT
Copy link
Contributor

This may be helped by open PR #4192, actually. @lhecker any idea?

@DHowett-MSFT DHowett-MSFT added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 23, 2020
@lhecker
Copy link
Member

lhecker commented Jan 24, 2020

Generally the issue here is - as far as I can see - that Ctrl+Alt is not the same as AltGr.
#4192 should fix this I suppose. I just need some free time to finally fix the failing unit tests. 😄

@lhecker
Copy link
Member

lhecker commented Jan 25, 2020

#4192 woudln't fix this issue... yet. Until now I planned to retain the current behavior as much as possible, which includes the AltGr handling. --> Using Ctrl+Alt in place of AltGr is currently not supported.

But I've checked ECMA-48 again and it clearly states that the second character of a C1 escape sequence must be in the range [0x40, 0x5F]. The current code supports pressing Ctrl during the creation of an escape sequnce though which is in violation of this spec.
If we drop this invalid behavior we can just treat AltGr the same as Ctrl+Alt - like Windows itself - and fix this issue as well.
Since I had to rewrite TerminalInput::HandleKey anyways I'll take the liberty to fix this issue within that single PR. 🙈

@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Jan 29, 2020
@ghost
Copy link

ghost commented Jan 29, 2020

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost ghost closed this as completed Feb 1, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity.
Projects
None yet
Development

No branches or pull requests

3 participants