Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSL shell tab not closed on exit if last command executed had a non-zero exit code #4355

Closed
slieschke opened this issue Jan 24, 2020 · 2 comments
Closed

WSL shell tab not closed on exit if last command executed had a non-zero exit code #4355

slieschke opened this issue Jan 24, 2020 · 2 comments
Labels
Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@slieschke
Copy link

Environment

Windows build number: 10.0.18363.592
Windows Terminal version (if applicable): 0.8.10091.0
No "closeOnExit" setting in my profile.

Steps to reproduce

  1. Open an WSL shell
  2. Run a command that results in a non-zero exit code
  3. Run exit

Expected behavior

The WSL shell tab closes

Actual behavior

The WSL shell tab remains open and it displays [process exited with code <exit code of previous command>].

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 24, 2020
@DHowett-MSFT
Copy link
Contributor

Far as we can tell, this is by design following the example of the ubuntu default terminal: #4223 (comment)

@DHowett-MSFT DHowett-MSFT added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Jan 24, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 24, 2020
@slieschke
Copy link
Author

Thanks @DHowett for the explanation. I've added "closeOnExit": "always" as you mentioned at #4223 (comment) and that's a good enough workaround for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slieschke @DHowett-MSFT