Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion about further improvements for the colored tab #4663

Closed
gbaychev opened this issue Feb 20, 2020 · 5 comments
Closed

Discussion about further improvements for the colored tab #4663

gbaychev opened this issue Feb 20, 2020 · 5 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.

Comments

@gbaychev
Copy link
Contributor

@zadjii-msft @DHowett As mentioned in #3789 I'm opening this issue to have a discussion about further improvements and adjustments of the tab's custom color selection. If this was not what you had in mind, please close the issue.

The idea about ability to pick a custom color for a tab is described in #2994. Currently (at least in my opinion) there are two, maybe three things, which need to be discussed:

  • Should the coloring of the split button be removed and exactly which pieces of code need to go away? Or should be this activated by a setting?
  • How to signify the selected tab? Currently a lot of alpha transparency is added to color of the deselected tabs, is this good enough?
  • There was a suggestion that the painting of the non-client is maybe provided as a follow-up PR. Is this really needed, in which from, when (after or before the implementation of the xaml themeing)?
@gbaychev gbaychev added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Feb 20, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 20, 2020
@DHowett-MSFT DHowett-MSFT added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Feb 21, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 21, 2020
@DHowett-MSFT DHowett-MSFT added Needs-Tag-Fix Doesn't match tag requirements and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 21, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 21, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone Feb 21, 2020
@DHowett-MSFT
Copy link
Contributor

(I tagged this one for discussion and put in on the backlog. Thanks for filing it!)

@gbaychev
Copy link
Contributor Author

gbaychev commented Feb 23, 2020

So, about the first two things:

  1. I think that the coloring of the split button should go away in any form. It is awkward and looks bad.
  2. Regarding the signifying of the selected tab - I did a thing
    image

Now the selected tab has a colored bar inside of it (like the orange one). Firefox does something pretty similar with its container tabs. Why within the tab and not above it? Because I need to calculate the color of the selection bar based on the tab's background. But this can collide with the color of the non-client area (even if they are different colors, a low contrast between them can make the indicator bar invisible).

Pros:

  • it is better visible than if slapped above the tab
  • hey, I can make the corner of the tabs round again

Cons:

  • the tab is a little bit fatter and the split button looks a bit rectangular

I think I can bring the indicator bar a little bit closer to the bottom.
Also I'm pretty sure this is the way to go in regards to the indicating the selected bar. What are your thoughts/feedback?

P.S. Currently the code is nowhere checked-in.

@jdhitsolutions

This comment has been minimized.

@zadjii-msft

This comment has been minimized.

@zadjii-msft
Copy link
Member

You know, we've let this discussion fester for a while. In the meantime though, we shipped colored tabs a while ago, and we really haven't had any complaints from people about which tab is selected. Honestly, people seem really happy with it as is (myself included!)

For housekeeping purposes, I'm gonna close this one out. Thanks again for working on this!

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants