-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build Error] Unresolved Settings.KeyChord &.Settings.IKeyBindings #540
Comments
Try adding a project reference in TerminalApp to the TerminalSettings project. |
I have the same issue.
Edit: Pardon my poor reading comprehension. I misread your comment and confused which project should be added as a reference to the other. Your suggestion did in fact work, thanks! |
Any chance this fix (adding a reference to |
hello @ThreeSevenths. Meanwhile I noticed that on (#560) says that we should explicitly add 141 tools, that I have already, but now I see no option to re-target for 141; I'm a bit confused b/c some people manage to build it on 142 |
Should the Nuget be installed inside "Packages"? because it my case it is empty; I removed it, and then I did a "Nuget restore", and it then re-created "Packages" folder, but it is still empty |
@alex285 Which version of Windows are you using to build the solution? If it is not on version 1903, you probably want to upgrade it to 1903 and try again. |
@chunliu im on 1903 and 18890.1000 from Skip Ahead; although that release to my understanding is on sync w Insiders Fast Ring |
i attach the full Solution Deploy output
and the error list (sorry no idea how to export that on text) |
@ThreeSevenths I had modified VS so I was missing some 141 components, although I re-installed them prior to my previous rebuild (above comment); but should we re-target the project for 141, or 141 just needs to be installed? because I see guys saying that they build if on 142, plus there are some commits for VS2019 support, so I assume that includes 142 tools Yes, I have recursively cloned |
|
Ok, I did not retarget the projects. You might have some success doing a |
@ThreeSevenths basically i cloned fresh with Windows Git because previously I was using WSL Git, just to make sure there is nothing weird going on this side Meanwhile I have tried everything, VS 2017 w 141, VS 2019 w both 141 and 142 ..i really really wanna see this project :(( Btw I keep getting that error
my "packages" folder is empty |
@alex285 |
and still "packages" is empty; can you please share the contents of 'packages` folder to see? |
@alex285 I get the same output but I do have some packages in my folder: |
wow!!
|
@alex285 maybe remove the package and try redownloading it? |
Haha, hit the show all files. VCproj still uses the old system where files have to be included in the project to show up in the solution explorer. Edit: Haha this is a funny thing I've encountered many times so I knew right away how this happens. Show all files is the icon in the solution explorer toolbar to the left of the properties (wrench) icon. |
thats the best proTip of the month :))) |
@alex285 - ok I am out of ideas, I'll ask tomorrow if they have come across your problem before. |
@ThreeSevenths thanks for your help anyway! eventually it will work! but since you have already built it, is is possible to send me the executable just to see it? :) |
see #565. Steps mentioned by |
@chunliu thank you for the detailed screenshots, but i have all those already. the only difference i can tell from your setup is my VS version; im on VS Community 2019 Preview - 16.1.0 Preview 3.0 |
@alex285 don't bother to build it anymore. Someone has shared a built version <link removed> |
@chunliu thank you!! nice one!! ..and ofc now im even more willing to build it :))) |
@jongio, Find the TerminalApp project, and add a reference to TerminalSettings. This should fix your build errors. |
@ThreeSevenths dont swear, b/c i already tried that :)) |
@alex285 I know you did :) Your problem is definitely different. But I do have to ask, you did delete all the packages from the filesystem and then run a fresh nuget restore, and that didn't help? |
One thing I can confirm is the build works with both VS2019 16.0.3 and 16.1.0 Preview 3. I've tried both successfully. |
@chunliu Can you confirm that this works on your machine? #565 (comment) I get the same error on mine. |
You literally mentioned the megathread (#489) for build issues in your opening post. Please try confining the discussion of build-related errors and problems to that thread, so we can have one resource for all issues, instead of 100 isues littered across the repo with various states of success. As far as this specific problem, it's actually also a dupe of #520. Make sure you do a nuget restore before you try building the project. If you're still hitting issues, try manually building the TerminalSettings project, which it's still unknown why that doesn't always build first. @chunliu please don't use this repo as a place to redistribute untrusted third-party binaries. When we're confident to publish a build that's ready for public consumption, we'll post the binary signed by Microsoft. |
@ThreeSevenths yeap i did! but i will re-try in a few days, maybe it will be provided some more reliable fix on master! thanks all for their help!! |
I successfully resolved this issue in VS2019 (after I bumped C++ dependencies from 141-142) by adding the TerminalSettings dependency to TerminalApp and building that separately. I also had some trouble finding the C++ v142 universal tools in VS2019, as they're an optional dependency for the Universal Windows Development suite but not listed separately in individual components 🤦 |
@c-ryan-k I'm curious if you were able to do the dependency without doing the update to 141. The v141 deps are listed in Individual Components. |
There are lots issues open w instructions (#489) & build errors , so I thought to open one more :)
Visual Studio 2019 / v142
SDK 10.0.18362.0
Release x64
Thats on
TerminalApp
, andTerminalSettings
are build without errors.The text was updated successfully, but these errors were encountered: