Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from profiles.json to settings.json broke my colorschemes #5611

Closed
VikingScientist opened this issue Apr 28, 2020 · 3 comments
Closed
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@VikingScientist
Copy link

Environment

Windows build number: Microsoft Windows NT 10.0.18362.0
Windows Terminal version (if applicable): 0.11.1121.0

Any other software? No

Steps to reproduce

Have a customized profiles.json file and upgrade to newest release which uses settings.json

Expected behavior

No change whatsoever

Actual behavior

None of my customized colorschemes seemed to work and they all reverted to their default values.

Fix for me

It would seem that settings.json is case-sensitive and requires the keyword to be written colorScheme, while I had previously used colorscheme.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 28, 2020
@zadjii-msft
Copy link
Member

Wow, if you had colorscheme in your settings file, you must have installed the Terminal an exceptionally long time ago. Thanks for sticking with us for so long through the preview process ❤️!

As you've found out, the colorscheme key was deprecated in favor of colorScheme. Largely, we're tracking all the "upgrade to 0.11 broke my settings" bugs with #5458, so I'm gonna close this thread as a duplicate.

Thanks!

/dup #5458

@ghost
Copy link

ghost commented Apr 28, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Apr 28, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 28, 2020
@nandesu
Copy link

nandesu commented May 4, 2020

Thanks for this. I spent hours creating my custom themes and was having the same issue. Finally just opened it in VSCode instead of vim and noticed that the scheme has this camel case key now.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants