Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Update fontFace to support multiple fonts #5634

Closed
anjc opened this issue Apr 29, 2020 · 2 comments
Closed

Feature Request: Update fontFace to support multiple fonts #5634

anjc opened this issue Apr 29, 2020 · 2 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@anjc
Copy link

anjc commented Apr 29, 2020

Description of the new feature/enhancement

I would like to be able to list multiple fonts in settings.json's fontFace property, so if the first font isn't available Terminal can attempt to choose from a series of fallbacks - which is what web developers [and VS Code users] do when storing multiple fonts in the font-family property.

This would be useful for people who sync Windows Terminal's settings across multiple devices (in my case, by fsutil hardlinking settings.json to a file in OneDrive) or share their configs with others, so the end-user can experience the modifications as-intended.

This would also allow Windows Terminal to have multiple fallbacks, like fontFace: "Cascadia Mono, Consolas", when a user enters an invalid font-name.

Proposed technical implementation details (optional)

I would recommend mirroring VS Code's implementation of this in their settings.json file: font names are separated by commas, with priority going from left-to-right.

@anjc anjc added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Apr 29, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 29, 2020
@DHowett-MSFT
Copy link
Contributor

Thanks for the request! This is a /dupe of #2664.

@ghost
Copy link

ghost commented Apr 29, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Apr 29, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 29, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants