Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+V (vertical selection in Vim) does not work #5641

Closed
vadimkantorov opened this issue Apr 29, 2020 · 6 comments
Closed

Ctrl+V (vertical selection in Vim) does not work #5641

vadimkantorov opened this issue Apr 29, 2020 · 6 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@vadimkantorov
Copy link

I guess it's because it's now bound by default to do paste.

I think it's quite a pain point for anyone new to Linux development on Window: vim basic functionality does not work :(

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 29, 2020
@vadimkantorov
Copy link
Author

I think MS Terminal should allow some Keybinding Profiles (like Visual Studio / ReSharper do) and hopefully it would be super-easy to change them. It may seem that satisfy everyone is impossible :(

@zadjii-msft
Copy link
Member

So we've probably had this discussion 1000 times across this repo now. The basic conclusion is always the same:

It may seem that satisfy everyone is impossible

When we only had Ctrl+Shift+C/Ctrl+Shift+V as the copy/paste keybindings, users were unhappy. Now that we've added back Ctrl+C/Ctrl+V, users are still unhappy.

With the new "default" settings in 0.11, the balance we've tried to compromise on is the following:

  • Ctrl+Shift+C/Ctrl+Shift+V are bound in defaults.json, and users will need to actually unbind those keys to disable their functionality.
    • These are the keybindings we've always had for copy-paste, so breaking them seemed like a terrible idea
    • Nobody was really complaining about these being used for copy/paste as opposed to something else
  • Ctrl+C/Ctrl+V are now listed in new user's settings.json file when they create a new settings file.
    • If they don't like them, it's trivial to just delete them from the file.
    • Ctrl+Shift+C/Ctrl+Shift+V will still work if the user deletes the Ctrl+C/Ctrl+V bindings from their settings.json

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. labels Apr 29, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 29, 2020
@vadimkantorov
Copy link
Author

vadimkantorov commented Apr 29, 2020

I understand there're tradeoffs. I understand one can fix manually the keybindings by editing settings.json. I understand this was discussed many times before.

The point of this issue is to point out a concrete example of very common, wide-spread vim functionality that breaks. This is not just "I don't like Ctrl+V", it is a problem that almost every vim-user will encounter. Since it's wide-spread, I think, it calls for more special consideration: e.g. big letters in README about this specifically or MessageBox on first launch, or an explicit invitation to change keybindings on the first launch, or sth else.

The profile idea would allow users to change multiple keybindings at once without encountering the problems and fixing them one by one. The same motivation applies to Microsoft Visual Studio / IntelliJ etc. If my preset is e.g. "Gnome Terminal", I'm sure everything will "just work" and have correct expectations about the chosen tradeoffs.

This is somewhat related: #5638

@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone Apr 30, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 30, 2020
@FossPrime
Copy link

FossPrime commented May 4, 2020

I'm actually having issues with ctrl+shift+v behaving erratically. It's not pasting new lines apparently. Right click doesn't work. Scroll doesn't work.

Can you please for once just allow us to select a default that makes this work like iterm, Terminator, Termux, Gnome Terminal and Mac's terminals. It's all we ask.

@DHowett-MSFT
Copy link
Contributor

So, this would ultimately be solved by /dup #5790, which I've promoted to be "profile-specific keybindings". FWIW: I don't like binding ^V by default either, but I more don't like how literally 50% of all our users yell at us regardless of the choice we made. 😄

All we can do is add more flexibility.

@ghost
Copy link

ghost commented May 15, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed May 15, 2020
@ghost ghost added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label May 15, 2020
@zadjii-msft zadjii-msft removed this from the Terminal Backlog milestone Jan 19, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants