-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Terminal] Cursor shape escape sequences not working #601
Comments
Yep that's correct, the cursor sequences aren't hooked up quite yet for the terminal. If someone wants to take their chances at implementing this themselves, I'd take a look at Terminal.h/cpp, TerminalApi.cpp, TerminalDispatch.cpp. I believe these two are the methods that need to be Implemented in TerminalDispatch: // From TermDispatch.hpp
virtual bool SetCursorStyle(const DispatchTypes::CursorStyle cursorStyle) = 0; // DECSCUSR
virtual bool SetCursorColor(const COLORREF Color) = 0; // OSCSetCursorColor, OSCResetCursorColor |
Hi! Is anybody working on this? I would like to take a stab at it! |
In my version -- latest released to date, and with Powershell Core -- the cursor still does not change shape in vim on WSL. |
I deleted a previous comment asserting that this is not fixed, which was incorrect. However, it is true that neither Vim nor Emacs seem to be able to detect (or detect reliably and/or accurately) the capabilities of the terminal to enable the cursor behavior that one would expect after using the GUI versions of those programs. I'm leaving this note for anyone who stumbles on this thread, as I did. You will likely need to amend your Vim or Emacs configuration to make cursor shape change as you expect. If you use Emacs, you may try the |
Your Windows build number: (Type
ver
at a Windows Command Prompt)Microsoft Windows [Version 10.0.18362.86]
What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots)
Using DECSCUSR escape sequences do not change the cursor shape, which is fixed to what it is set in
profiles.json
.What's wrong / what should be happening instead:
Cursor shape changes like it does in
conhost
, see conhost above and Terminal below:AFAICT all sequences here are supported in conhost, and larger values (e.g.
echo -e -n "\x1b[\x37 q"
) changes it to the "legacy underscore" version. Also related #68.The text was updated successfully, but these errors were encountered: