Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to remove bottom padding #6021

Closed
metaltermite opened this issue May 20, 2020 · 2 comments
Closed

Unable to remove bottom padding #6021

metaltermite opened this issue May 20, 2020 · 2 comments
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Answered Related to questions that have been answered

Comments

@metaltermite
Copy link

There is too much bottom padding, which is fine by default, but setting the bottom padding to 0 doesn't reduce the bottom padding to the bottom window margin as you'd expect, there's still a fair amount of padding.

Annotation 2020-05-20 021735

(Also Setting bottom padding to -1, doesn't reduce it; setting bottom padding to -2, reduces the padding but the bottom margin gets clipped.)

Environment

Windows build number:  10.0.18363.836
Windows Terminal version (if applicable): 1.0.1401.0

Any other software?

Steps to reproduce

Run any app, such as byobu, that draws a horizontal bar at the bottom of the terminal to gauge the size of the padding. Set bottom padding to 0, "padding": "0, 0, 0, 0"

Expected behavior

The bottom margin should be flush with the bottom of the terminal window

Actual behavior

There's still a fair amount of bottom padding.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 20, 2020
@zadjii-msft
Copy link
Member

This is unfortunately by-design. That space that's there on the bottom of the window isn't big enough for an entire row of text, so we just fill it with blank space. That's generally preferable to a row of characters that's only partially visible. Otherwise, the only solution would be to prevent the window from filling the entire screen while maximized, which I'm sure that no one really wants.

Thanks!

@bkkm78
Copy link

bkkm78 commented Jun 27, 2024

The kitty terminal, for example, has a placement_strategy property that can be used to configure the placement of the terminal area with respect to the window (and therefore where the paddings are placed). When set to center, you get two smaller paddings at the top and the bottom instead of one fat padding at the bottom only, partially mitigating the problem. I guess many would also prefer the bottom strategy that moves the padding to the top, as programs like tmux and vim have status bars at the bottom by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Answered Related to questions that have been answered
Projects
None yet
Development

No branches or pull requests

3 participants