Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialRows still isn't working completely right #6373

Closed
keathmilligan opened this issue Jun 5, 2020 · 5 comments
Closed

initialRows still isn't working completely right #6373

keathmilligan opened this issue Jun 5, 2020 · 5 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Milestone

Comments

@keathmilligan
Copy link

Environment

Windows build number: 10.0.19041.0
Windows Terminal version (if applicable): 1.0.1401.0

Steps to reproduce

Set InitialRows to 40.
Open Windows Terminal.
In Powershell, run:

for ($i = 1; $i -le 40; $i++) { Write-Host; Write-Host -NoNewLine $i }; [console]::ReadKey()

Expected behavior

You should see all 40 rows.

Actual behavior

Instead, you only see rows 2-40. The area of the window that should contain the last row is not used:

image

Now grab the bottom edge of the window, shrink it by one and then return it to its original size. Run the script above again and see that all 40 rows are now displayed with the last row being utilized.

image

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 5, 2020
@DHowett
Copy link
Member

DHowett commented Jun 5, 2020

Huh, I can't reproduce this.

  • What's your DPI display scaling?
  • Can you run mode con?
  • Can you select the blank line under 40?

@DHowett DHowett added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 5, 2020
@keathmilligan
Copy link
Author

DPI scaling is 150% on a 4k display.

When I first open the window, before manually resizing, mode con shows 39 lines even though InitialRows is set to 40. And no, the blank line cannot be selected.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 5, 2020
@DHowett
Copy link
Member

DHowett commented Jun 5, 2020

Thanks! I thought we had a duplicate of this, but I think we thought we'd fixed it.

@DHowett DHowett changed the title Last row not used until window is resized initialRows still isn't working completely right Jun 5, 2020
@DHowett DHowett added Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Jun 5, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 5, 2020
@DHowett DHowett added Priority-3 A description (P3) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 5, 2020
@DHowett DHowett added this to the Terminal v1.x milestone Jun 5, 2020
@DHowett DHowett removed the Needs-Attention The core contributors need to come back around and look at this ASAP. label Jun 5, 2020
@zadjii-msft
Copy link
Member

Hey I think we fixed this in 1.5 / 1.6 - there was #8527 (which has almost exactly the same title) which should be fixed

🎉This issue was addressed in #8584, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.🎉

I'm more shocked that we didn't dupe that other issue to this one in the first place

/dup #8527

@ghost
Copy link

ghost commented Feb 9, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Feb 9, 2021
@ghost ghost added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Feb 9, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants