Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WT_VERSION Environment Variable #6798

Closed
tracker1 opened this issue Jul 6, 2020 · 3 comments
Closed

WT_VERSION Environment Variable #6798

tracker1 opened this issue Jul 6, 2020 · 3 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@tracker1
Copy link

tracker1 commented Jul 6, 2020

In addition to the WT_PROFILE_ID and WT_SESSION, would be nice to see a WT_VERSION environment variable as well... this could be used to allow some level of feature detection in order to allow some more advanced features without complex interrogation.

Such as with #204 when implemented, such as via supports-hyperlinks
@tracker1 tracker1 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 6, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 6, 2020
@zadjii-msft
Copy link
Member

This feels like the wrong solution to this problem IMO. When the Terminal does eventually get hyperlink support, it will come first through the Windows Console. In that case, both the console and the Terminal will support hyperlinks, but if people rely on the presence of WT_VERSION, then the console will incorrectly be detected as not supporting hyperlinks.

@zadjii-msft zadjii-msft added Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. labels Jul 6, 2020
@DHowett
Copy link
Member

DHowett commented Jul 6, 2020

Yeah, I'm going to NAK this one hard. It's also somewhat of a /duplicate of #1040 😄

@ghost
Copy link

ghost commented Jul 6, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jul 6, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 6, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DHowett @tracker1 @zadjii-msft