Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window title is inconsistently updated with tab rename #6814

Closed
jtippet opened this issue Jul 7, 2020 · 4 comments · Fixed by #7119
Closed

Window title is inconsistently updated with tab rename #6814

jtippet opened this issue Jul 7, 2020 · 4 comments · Fixed by #7119
Assignees
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@jtippet
Copy link
Contributor

jtippet commented Jul 7, 2020

Environment

Windows build number: 10.0.19041.329
Windows Terminal version (if applicable): d350a8932485f618b1658353a0573ac2422a3c36 and also repros in 1.1.1812.0

Steps to reproduce

  1. Launch Terminal
  2. Create a 2nd tab
  3. Rename the inactive tab to anything, like "bananas"
  4. Switch to the inactive tab
  5. Check the top-level window's title text (e.g., by looking at the label in the ALT+TAB experience)

Expected behavior

I'd expect the top-level window's title text to always match the active tab's title (_runtimeTabText).

Actual behavior

The top-level window's title text is just the default tab title. If you rename the tab while it's the active tab, then the top-level window title is updated... until you switch away from the tab. Once you return back to the tab, the top-level window has returned to the default title for the tab.

This is the console:
image

But this is what ALT+TAB thinks it's titled -- I'd expect it to say "bananas" at the top, not "PowerShell":
image

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 7, 2020
@DHowett
Copy link
Member

DHowett commented Jul 10, 2020

We should definitely go audit our event handlers and the stack that carries titles up out of the application to its final termini. Thanks!

@DHowett DHowett added Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jul 10, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 10, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 10, 2020
@DHowett DHowett modified the milestones: terminal 2.0, Terminal v2.0 Jul 10, 2020
@JakubKoralewski
Copy link

Even with this bug fixed, I could see a use case for me where I would like for the custom title tab to overwrite all other titles. Could this be a profile setting, or even better ", a more flexible solution - a little lock icon when renaming the title tab to lock that title to the window title regardless of the number of tabs inside that window/instance? Or even simpler to be able to change the window's title directly and independently from the tab title?

I got confused with lots of ideas 😅

I often open a few instances of the terminal each with a few tabs, grouped by e.g.: frontend, backend etc. specific commands so the use case I'm thinking of is labeling the window as one of the above, so when I have ten instances minimized I can quickly see which is which and binary search for the problem.

Sorry for the rant.

@zadjii-msft
Copy link
Member

@JakubKoralewski You mean something like this?
rename-tab-002

#1079, #6600, #6557

If your use case is "one window per environment", then (once this bug is fixed) you could rename the tab for each environment, and the window title should reflect the active tab's title.

Otherwise, there's also #4183 which looks like it's related

@ghost ghost added the In-PR This issue has a related PR label Jul 29, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 30, 2020
@ghost
Copy link

ghost commented Aug 13, 2020

🎉This issue was addressed in #7119, which has now been successfully released as Windows Terminal Preview v1.2.2234.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants