Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Terminal 1.1 breaks WinCompose input #7089

Closed
mordquist opened this issue Jul 27, 2020 · 6 comments
Closed

Windows Terminal 1.1 breaks WinCompose input #7089

mordquist opened this issue Jul 27, 2020 · 6 comments
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Milestone

Comments

@mordquist
Copy link

Environment

Windows build number: 10.0.19041.0
Windows Terminal version (if applicable): 1.1.2021.0

Any other software?
Ubuntu 20.04 LTS (WSL2)
WinCompose v0.9.4 (https://github.com/samhocevar/wincompose/releases/tag/v0.9.4)

Steps to reproduce

  1. Start WinCompose and Windows Terminal (cmd, powershell, or WSL does not matter)
  2. Input any character using the WinCompose compose key
    e.g. rightAlt + o a

Expected behavior

The correct character ('å' in the above example) is sent to the terminal.

Actual behavior

Seemingly no character is sent, at least nothing is displayed.

Probably related to #6309 as setting "experimental.input.forceVT": true gives the expected behavior.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 27, 2020
@zadjii-msft zadjii-msft added Area-Input Related to input processing (key presses, mouse, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels Jul 27, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 27, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Jul 27, 2020
@DHowett
Copy link
Member

DHowett commented Jul 27, 2020

Huh. This doesn't exactly work in the traditional console either, and it was somewhat of a fluke that it worked in WT. It should, though.

This is what I get if I peek at the key events coming out of WC into the traditional console:

v 001 0010 002a 0000 ^@   00000010
^ 001 0010 002a 0000 ^@   00000000
v 001 0000 0000 00f6 �    00000000
^ 001 00e7 0000 00f6 �    00000000
^ 001 004f 0018 006f o    00000000

and here's what I'm getting over the tap:

␛[255;0;0;1;16;1_␛[255;0;0;0;16;1_

that 255 definitely ain't right

@samhocevar
Copy link

So, how should a third-party application send Unicode characters to Windows Terminal if SendInput() no longer works by default?

@lhecker
Copy link
Member

lhecker commented Nov 26, 2020

As far as I can see, this issue was fixed in #7900. I'll close this issue for now as WinCompose works just fine on my end with the latest WT version.

The good thing is that I now finally understood, why we've been receiving weird key events, containing invalid scan codes, for third party applications employing SendInput: WT doesn't use TranslateMessage(Ex) properly. (I mean there's a very specific reason it doesn't... Namely the necessity to receive key events even for character keys.)

@lhecker lhecker closed this as completed Nov 26, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Nov 26, 2020
@mordquist
Copy link
Author

I can confirm that it works for me as well on Terminal 1.4 even with "experimental.input.forceVT" unset.

@smooth038
Copy link

I don't know if maybe this problem got recently reintroduced, but WinCompose currently does not work with any window terminal on my machine (cmd, powershell or windows terminal). When typing rightAlt ' a, it just outputs 'a and the compose key is ignored.

I tried the "experimental.input.forceVT" setting, but it doesn't seem to do anything.

Can anyone else reproduce this?

@smooth038
Copy link

smooth038 commented Apr 15, 2023

I just found the problem. It didn't work because I was running the terminals in administrator mode, but WinCompose did not have admin privileges. When WinCompose is run as admin, everything works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

6 participants