dircolors with background color set highlights to end of line

[zedtools]

Environment

Windows build number: 10.0.19041.450
Windows Terminal version 1.2.2234.0

Any other software? No

Steps to reproduce

I am using zsh on WSL Ubuntu.

Put the following in ~/.dircolors:
OTHER_WRITABLE 30;42

Then run:
eval $( dircolors -b $HOME/.dircolors )

Finally, fill up the terminal screen (e.g. pressing ENTER repeatedly) so that prompt is at the bottom of the window, and run:
ls -l

Expected behavior

When running ls -l to view a writable directory, the directory name should be highlighted.

Actual behavior

If the highlighted directory name spans across a newline, and the ls output scrolls past the bottom of the window, then the entire second line is highlighted.

See screenshot below. The second ls -l caused the terminal to scroll past the bottom of the window, and long_dir_name is incorrectly highlighted.

[zadjii-msft]

You know, I thought this was #3848, but this doesn't have anything to do with resizing, so this might not actually be that. And it's not #32 either, because again, there's no resizing happening.

I'm not totally sure what's happening here. I'll toss this on the v2 milestone to figure out. Thanks! (I'm tentatively tossing this on Product-Terminal, but this is probably Product-Conhost)

[j4james]

I believe this is working as intended. If the background color is set when the screen scrolls (which is what is happening here), then the newly revealed line is filled with that background color. I think you'll find the same behaviour on all terminals that support background color erase.

[zedtools]

Hmm... I just tried this with mintty on Windows, and iTerm2 on MacOS. Both of them behave the same as above, so you may be correct.

Resizing the window is different. If i resize iTerm2, the background colour stays unchanged. If I resize Windows Terminal, the background colour is fixed so that it is not highlighted to the end of the line. It's a minor inconsistency, though I am not sure which behaviour is correct.

Based on this, I am happy to leave the current behaviour unchanged.

[zadjii-msft]

Oh, okay, thanks for the follow up! I guess I triaged this without even checking other terminals 😅

As far as the color highlighting till the end of the line issue, that'll be #32.

Thanks!