Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Functional-Command Palette]- User is not able to perform action using shortcuts when command palette is open. #7914

Closed
DasaradhaKamjula opened this issue Oct 13, 2020 · 8 comments
Closed

[Functional-Command Palette]- User is not able to perform action using shortcuts when command palette is open. #7914

DasaradhaKamjula opened this issue Oct 13, 2020 · 8 comments
Labels
Area-CmdPal Command Palette issues and features Area-User Interface Issues pertaining to the user interface of the Console or Terminal Fixed Issues assigned by the accessibility team that have been fixed. HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Impact-Compliance It gotta be this way. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v2.0

Comments

@DasaradhaKamjula
Copy link
Collaborator

DasaradhaKamjula commented Oct 13, 2020 •
edited
Loading

User Experience:
Users who rely on screen reader/Keyboard will not be able to perform action efficiently if shortcuts are not working when command palette is open

Test Environment:
App: Windows Terminal Preview
Feature: Command Palette
OS: Win 10 2004 Build (19041.508)

Repro Steps:
1.Open Windows terminal Preview app
2.Open Command Palette using shortcut (Ctrl+shift+p)
3.Verify whether user is able to perform any shortcut operation when command palette is open.

Actual:
User is not able to perform action using shortcuts when command palette is open.

Expected:
User should be able to perform the shortcut operation even when the command palette is open.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 13, 2020
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Impact-Compliance It gotta be this way. labels Oct 13, 2020
@zadjii-msft
Copy link
Member

@cinnamon-msft @DasaradhaKamjula What's the process for resolving these issues as dupes? We've already got #6679 tracking this same issue

@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 13, 2020
@zadjii-msft zadjii-msft mentioned this issue Oct 13, 2020
Open
52 tasks
@zadjii-msft zadjii-msft added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Oct 13, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 13, 2020
@ghost

This comment has been minimized.

Sign in to view
@ghost ghost closed this as completed Oct 14, 2020
@cinnamon-msft cinnamon-msft reopened this Oct 14, 2020
@ghost

This comment has been minimized.

Sign in to view
@ghost ghost closed this as completed Oct 15, 2020
@zadjii-msft zadjii-msft reopened this Oct 15, 2020
@zadjii-msft zadjii-msft removed the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Oct 15, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Oct 15, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Oct 15, 2020
@cinnamon-msft cinnamon-msft added the HCL-E+D Accessibility tracking label Oct 20, 2020
@ghost
Copy link

ghost commented Oct 21, 2020

I’m going to work on this.

@zadjii-msft
Copy link
Member

@Hegunumo thanks! Be careful while working on this one - it might be trickier than it seems on the surface. I tried doing this before, by passing the ShortcutActionDispatch to the CommandPalette, but there were enough weird edge cases that I never followed up on it. There's a bunch more notes of the pitfalls I found in #6679.

If you need any help, feel free to ask questions ☺️

@ghost ghost mentioned this issue Oct 26, 2020
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Oct 26, 2020
@zadjii-msft zadjii-msft added the Area-CmdPal Command Palette issues and features label Dec 1, 2020
@ghost ghost removed the In-PR This issue has a related PR label Dec 3, 2020
@Chandresh1007 Chandresh1007 added HCL-WindowsConsole Accessibility tracking HCL-WindowsTerminal Accessibility tracking labels Dec 7, 2020
@Priyanka-Chauhan123 Priyanka-Chauhan123 removed the HCL-WindowsConsole Accessibility tracking label Jul 21, 2021
@zadjii-msft
Copy link
Member

@Chandresh1007 @Priyanka-Chauhan123 @DasaradhaKamjula I believe this is fixed in newer versions of the Terminal. (fixed in #8586). Could you confirm and close this?

@zadjii-msft zadjii-msft added Fixed Issues assigned by the accessibility team that have been fixed. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Aug 19, 2021
@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Aug 23, 2021
@ghost
Copy link

ghost commented Aug 23, 2021

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@Priyanka-Chauhan123
Copy link
Collaborator

Issue is fixed. Verified on Windows Terminal Version: 1.9.1942.0. Hence, closing the bug.

@ghost ghost removed the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CmdPal Command Palette issues and features Area-User Interface Issues pertaining to the user interface of the Console or Terminal Fixed Issues assigned by the accessibility team that have been fixed. HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Impact-Compliance It gotta be this way. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v2.0
Development

No branches or pull requests
5 participants
@zadjii-msft @DasaradhaKamjula @cinnamon-msft @Chandresh1007 @Priyanka-Chauhan123