Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tab icon according to remote machine name & own config #8064

Closed
gfcroft opened this issue Oct 27, 2020 · 8 comments
Closed

Change tab icon according to remote machine name & own config #8064

gfcroft opened this issue Oct 27, 2020 · 8 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@gfcroft
Copy link

gfcroft commented Oct 27, 2020

Description of the new feature/enhancement

I use windows sub-system for linux (WSL) a lot with windows terminal (WT) to SSH remote machines, I have created profiles for some of the main machines I SSH, so that when I open the profile for that remote machine SSH, it has an identifiable icon

image

It would be great if rather than create a profile for each machine I SSH to, and have to stay in it (else I lose the icon change)
there could be a feature that allows a user to set up a config of machine names in their settings.json, which points to specific icons they have set, then have WT automatically update the tab icon with the icon that has been associated with the machine name, when they SSH over to the different machine

@gfcroft gfcroft added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 27, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 27, 2020
@gfcroft gfcroft changed the title WSL: Change tab icon according to remote machine name & own config Change tab icon according to remote machine name & own config Oct 27, 2020
@DHowett
Copy link
Member

DHowett commented Oct 27, 2020

Thanks for the request! /dup #1868

@ghost
Copy link

ghost commented Oct 27, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Oct 27, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 27, 2020
@DHowett
Copy link
Member

DHowett commented Oct 27, 2020

If we're going to make this configurable I'd rather just go all the way and make it app-driven. I think that WT trying to detect a hostname is going to be error-prone, and isn't going to get us what we want. 😄

@gfcroft
Copy link
Author

gfcroft commented Oct 27, 2020

Sorry for the dup.

Would it be possible to define what you mean by app-driven please?

@DHowett
Copy link
Member

DHowett commented Oct 27, 2020

Sure! So, just like the app can set the title, there's a couple well-defined VT sequences that let the application set an icon. That'd be more like your remote shell or something saying "here, set the icon to this PNG file". It would let you go above/beyond simple hostname recognition and have the icon change when an operation was in-progress or when you were connected to a production cluster, etc.

@gfcroft
Copy link
Author

gfcroft commented Oct 27, 2020

Thanks for that clarification

In which case I think the discussion on the original ticket and your good point highlights how using VT sequences would be a fundamentally better way around this

I am assuming that because the existing VT Sequence I see on Console APIs (https://docs.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences#output-sequences) are by Microsoft, creation of new VT sequences would be reserved for the Microsoft team?

@DHowett
Copy link
Member

DHowett commented Oct 27, 2020

Nope! We actually try to avoid making our own VT sequences whenever possible. We use a bunch of other standard and quasi-standard documented sequences, like the xterm ones and many things that DEC terminals can handle

@gfcroft
Copy link
Author

gfcroft commented Oct 27, 2020

Great!

So it sounds like the way to resolve #1868 any other tickets relating to similar dynamic terminal content, would be to create a new issue in this project for inventing a custom Windows Terminal VT sequence (I can't find an issue which is already covering this, but as shown by the dup. my git issue searching skills are wanting...)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants