Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing desktop wallpaper doesn't change Terminal background #8231

Open
Masamune3210 opened this issue Nov 12, 2020 · 7 comments
Open

Changing desktop wallpaper doesn't change Terminal background #8231

Masamune3210 opened this issue Nov 12, 2020 · 7 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@Masamune3210
Copy link

Masamune3210 commented Nov 12, 2020 •
edited
Loading

Description of the new feature/enhancement

Love the new feature to autodetect and use the desktop wallpaper, would it be possible to select what monitor to pull the wallpaper from and to detect when the wallpaper has changed and use the new one if only for new profiles launched after the change?

Proposed technical implementation details (optional)

User can select the monitor to use for the autodetect and the app uses that wallpaper until it changes either manually or automatically, then the app notices the change and either changes all backgrounds or at least backgrounds for any new profile launches
@Masamune3210 Masamune3210 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 12, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 12, 2020
@Masamune3210
Copy link
Author

Sorry for the derped up issue template, misunderstood how to use it

@DHowett
Copy link
Member

DHowett commented Nov 17, 2020

Thanks for the request! I wonder if this will automatically be handled by dispatching a settings reload on WM_SETTINGSCHANGE (which we have a workitem tracking 😄)

@DHowett DHowett added Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Nov 17, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 17, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 17, 2020
@DHowett DHowett added this to the Terminal Backlog milestone Nov 17, 2020
@Masamune3210
Copy link
Author

Not a problem at all! Love the app and use it literally 24/7 on one of my boxes!

@luxzg luxzg mentioned this issue Dec 3, 2020
Closed
@Masamune3210
Copy link
Author

Any update on this possibly being a thing? Dont want to be a bother but its still not been added and wasn't sure if it was in the plans or not

@zadjii-msft
Copy link
Member

Nope. We'll make sure to update this thread when there is. In the meantime, might I recommend the Subscribe button?
image
That way you'll be notified of any updates to this thread. It's also marked help wanted, so if you're really passionate about it, go right ahead.

FWIW, the "dispatching a settings reload on WM_SETTINGCHANGE" bit is tracked in #1125

@Masamune3210
Copy link
Author

Already subscribed to issues in general on here so I can help people when I notice something I can help with, just wanted to make sure that this issue didn't get lost out to sea so to speak. Love the program and everything you guys have done so try to help whenever I can

@Masamune3210
Copy link
Author

Would give a crack myself, but not super sure of myself in programming yet, learning it slowly but not quite there yet

@zadjii-msft zadjii-msft mentioned this issue Nov 3, 2021
Closed
@zadjii-msft zadjii-msft changed the title Grab new wallpaper if it has changed between start of app and new profile launch Changing desktop wallpaper doesn't change Terminal background Nov 3, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@DHowett @Masamune3210 @zadjii-msft