Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startupActions to Settings UI #8802

Open
carlos-zamora opened this issue Jan 15, 2021 · 4 comments
Open

Add startupActions to Settings UI #8802

carlos-zamora opened this issue Jan 15, 2021 · 4 comments
Labels
Area-Settings UI Anything specific to the SUI In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@carlos-zamora
Copy link
Member

carlos-zamora commented Jan 15, 2021

Similar to #8755. These are settings that were added to v1.6 that need to be added to the Settings UI (or include reasoning for why not add them):

Setting Required? Notes
startupActions #8770

This may not be a comprehensive list. @cinnamon-msft is verifying if any are missing and will update this issue accordingly.
EDIT: verified that startupActions is the only one. Updating the issue title appropriately.

Resources:

@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-Settings UI Anything specific to the SUI labels Jan 15, 2021
@carlos-zamora carlos-zamora added this to the Terminal v1.6 milestone Jan 15, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 15, 2021
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 15, 2021
@DHowett
Copy link
Member

DHowett commented Jan 16, 2021

This seems a little more advanced, and a late bring-in to get into the settings UI. For it to work properly, we would need to fully parse the commandline string inside the SUI just to make sure it's valid before we let the user commit it. I don't know if we should try to push to get this into 1.6.

@DHowett
Copy link
Member

DHowett commented Jan 16, 2021

image

image

We would probably want the same behavior in the SUI as well, right? That's not 1.6 territory given how close we are to the snap date.

@Don-Vito
Copy link
Contributor

image

image

We would probably want the same behavior in the SUI as well, right? That's not 1.6 territory given how close we are to the snap date.

Yes. This is exactly what I was planning to do here 😄

@Don-Vito
Copy link
Contributor

Don-Vito commented Jan 17, 2021

@DHowett - I added the setting itself to UI, however there is an issue adding the parsed command line, as the parsing logic is a part of AppCommandlineArgs, which are is a part of TerminalApp, and thus Settings.Editor is not familiar with it.

Probably we should extract the AppCommandlineArgs into a separate lib and make Editor depend on it? WDYT?

@ghost ghost added the In-PR This issue has a related PR label Jan 17, 2021
@carlos-zamora carlos-zamora changed the title Missing v1.6 Settings in Settings UI Add startupActions to Settings UI Jan 21, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft removed this from the 22H2 milestone Dec 5, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings UI Anything specific to the SUI In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

5 participants