Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error state in progress ring of tab #9481

Open
Tracked by #6700
KalleOlaviNiemitalo opened this issue Mar 13, 2021 · 5 comments
Open
Tracked by #6700

Show error state in progress ring of tab #9481

KalleOlaviNiemitalo opened this issue Mar 13, 2021 · 5 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@KalleOlaviNiemitalo
Copy link

KalleOlaviNiemitalo commented Mar 13, 2021

Description of the new feature/enhancement

If an application reports progress via OSC 9;4, Windows Terminal nowadays shows that in the task bar and in the tab header (#8133). However, if the progress report has the error or warning state, that information goes only to the task bar. I'd like the tab header to display the error or warning, too.

Related to #6700 and #9435 (comment).

Proposed technical implementation details (optional)

Could perhaps change the color of the progress ring. I don't see any color or error property in Microsoft.UI.Xaml.Controls.ProgressRing, though.

@KalleOlaviNiemitalo KalleOlaviNiemitalo added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Mar 13, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 13, 2021
@KalleOlaviNiemitalo
Copy link
Author

KalleOlaviNiemitalo commented Mar 14, 2021

Changing the colors of a ProgressRing is apparently microsoft/microsoft-ui-xaml#1968.

If Windows Terminal instead displayed the error and warning states by changing the tab color, then it would have to be decided how that interacts with tab colors set by applications (#6574); and if the tab color could be set in a color scheme (#9413), then perhaps the tab error and warning colors should be configurable there as well.

@DHowett
Copy link
Member

DHowett commented Mar 14, 2021

If we're willing to dispense with the progress part of the ring during an error state, we could mimic it with an elliptical path. That would give us the freedom to style it and perhaps even animate it. Likely that we'd be able to do that before microsoft/microsoft-ui-xaml#1968 lands ;P

@zadjii-msft
Copy link
Member

we could mimic it with an elliptical path. That would give us the freedom to style it and perhaps even animate it

Yea that's a neat idea. If we're in the error/warning states, then we're not in the indeterminate state that needs the interesting animation anyways. A neat workaround 😉

@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Mar 15, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 15, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Mar 15, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 15, 2021
@KalleOlaviNiemitalo
Copy link
Author

The WinUI 3.0 documentation for ProgressRing now lists a Foreground property inherited from Microsoft.UI.Xaml.Controls.Control. It seems ProgressRing in WinUI 2.7 already inherited a Foreground property from Windows.UI.Xaml.Controls.Control but this was just not listed in the documentation. From ProgressRing.xaml and ProgressRing.cpp in WinUI 2.7, it looks like the property should affect the displayed color if set. I'm not sure where the WinUI 3.0 ProgressRing source code is, as ProgressRing even on the main branch of microsoft/microsoft-ui-xaml is derived from Windows.UI.Xaml.Controls.Control rather than Microsoft.UI.Xaml.Controls.Control.

@mpela81
Copy link
Contributor

mpela81 commented Oct 20, 2021

If we like @KalleOlaviNiemitalo's suggestion the ProgressRing's Foreground property seems to work
ProgressRingForeground

@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants