From 8df7172643a914a8d6893ca81ad5b10deadd0630 Mon Sep 17 00:00:00 2001 From: Leonard Hecker Date: Tue, 23 Apr 2024 15:25:26 +0200 Subject: [PATCH] Fix TerminalPage not being released on window close --- src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp | 2 -- src/cascadia/WindowsTerminal/NonClientIslandWindow.h | 1 - 2 files changed, 3 deletions(-) diff --git a/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp b/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp index bab65132266..73a2ea89443 100644 --- a/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp +++ b/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp @@ -405,8 +405,6 @@ bool NonClientIslandWindow::Initialize() // - void NonClientIslandWindow::SetContent(winrt::Windows::UI::Xaml::UIElement content) { - _clientContent = content; - _rootGrid.Children().Append(content); // SetRow only works on FrameworkElement's, so cast it to a FWE before diff --git a/src/cascadia/WindowsTerminal/NonClientIslandWindow.h b/src/cascadia/WindowsTerminal/NonClientIslandWindow.h index b2cbb5a8a29..bf9c815237c 100644 --- a/src/cascadia/WindowsTerminal/NonClientIslandWindow.h +++ b/src/cascadia/WindowsTerminal/NonClientIslandWindow.h @@ -58,7 +58,6 @@ class NonClientIslandWindow : public IslandWindow std::optional _oldIslandPos; winrt::TerminalApp::TitlebarControl _titlebar{ nullptr }; - winrt::Windows::UI::Xaml::UIElement _clientContent{ nullptr }; wil::unique_hbrush _backgroundBrush; til::color _backgroundBrushColor;