Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build definition auth #17

Merged
merged 38 commits into from
Jul 17, 2020
Merged

Add build definition auth #17

merged 38 commits into from
Jul 17, 2020

Conversation

EliiseS
Copy link
Member

@EliiseS EliiseS commented Jun 26, 2020 •
edited
Loading

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Add support to authorize resources for a build

Issue Numbers:

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

@ghost ghost added the size/L label Jun 26, 2020
@EliiseS EliiseS added the draft This issue or pull requests is in progress label Jun 26, 2020
@ghost ghost added size/XL and removed size/L labels Jun 29, 2020
tmeckel
tmeckel reviewed Jun 30, 2020
View reviewed changes
Copy link
Contributor

@tmeckel tmeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the linting errors in my PR #18 already

.vscode/settings.json Outdated Show resolved Hide resolved
@EliiseS EliiseS mentioned this pull request Jul 8, 2020
Closed
@EliiseS EliiseS linked an issue Jul 9, 2020 that may be closed by this pull request
Missing "path" parameter documentation in docs #68
Closed
@ghost ghost added the documentation label Jul 9, 2020
tmeckel
tmeckel suggested changes Jul 15, 2020
View reviewed changes
.vscode/launch.json Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
azuredevops/internal/service/build/resource_resource_authorization.go Outdated Show resolved Hide resolved
azuredevops/internal/service/build/resource_resource_authorization.go Outdated Show resolved Hide resolved
xuzhang3
xuzhang3 reviewed Jul 16, 2020
View reviewed changes
GNUmakefile Outdated Show resolved Hide resolved
xuzhang3
xuzhang3 reviewed Jul 16, 2020
View reviewed changes
GNUmakefile Outdated Show resolved Hide resolved
xuzhang3
xuzhang3 reviewed Jul 16, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
xuzhang3
xuzhang3 requested changes Jul 16, 2020
View reviewed changes
Copy link
Collaborator

@xuzhang3 xuzhang3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EliiseS This PR is great. I left some comments, :D

@EliiseS EliiseS force-pushed the es/add-build-definition-resource-auth branch from 330b3f1 to 9cc7d59 Compare July 16, 2020 18:12
tmeckel
tmeckel suggested changes Jul 16, 2020
View reviewed changes
GNUmakefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
azuredevops/internal/service/build/resource_resource_authorization.go Outdated Show resolved Hide resolved
xuzhang3
xuzhang3 reviewed Jul 17, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@ghost ghost added size/XXL and removed size/XL labels Jul 17, 2020
@EliiseS @xuzhang3
Update website/docs/r/build_definition.html.markdown
a73de39 
Co-authored-by: xuzhang3 <57888764+xuzhang3@users.noreply.github.com>
tmeckel
tmeckel suggested changes Jul 17, 2020
View reviewed changes
.vscode/launch.json Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
@EliiseS EliiseS merged commit afce8b1 into microsoft:master Jul 17, 2020
@EliiseS EliiseS deleted the es/add-build-definition-resource-auth branch July 17, 2020 13:23
@tmeckel tmeckel mentioned this pull request Jul 17, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeckel tmeckel tmeckel requested changes

@xuzhang3 xuzhang3 xuzhang3 requested changes

@nmiodice nmiodice Awaiting requested review from nmiodice

Assignees
No one assigned
Labels
documentation new-feature size/XXL
Projects
None yet
Milestone
No milestone
3 participants
@EliiseS @tmeckel @xuzhang3