Assertion arguments should be passed in the correct order

[Evangelink]

Summary

The standard assertions library methods such as AreEqual and AreSame expect the first argument to be the expected value and the second argument to be the actual value.

Having the expected value and the actual value in the wrong order will not alter the outcome of tests, (succeed/fail when it should) but the error messages will contain misleading information.

This rule raises an issue when the actual argument to an assertions library method is a hard-coded value and the expected argument is not. We assume that a literal, constant or variable/field/property containing expected in its name is the expected value and that any variable containing actual is the actual value.

Category: Assertion
Enabled by default: True
Default severity: Info

AB#1992481

[testplatform-bot]

✅ Successfully linked to Azure Boards work item(s):

• User Story 1992481

[fforjan]

@Evangelink you were asking for some inputs, a code fix for this rule would be welcome ! We have 600 of this issue in our code base, it will be good to have a code fix to allow us to quickly fix it instead of manually fixing it !