MTP extensions - problem between 1.5.3 and 1.6.0

[Evangelink]

Describe the bug

Bump TRX report on the given sample to 1.6.0 and there will be crash.

test_plat_sent-fixed.zip

[Youssef1313]

This is due to the rename of internal property from TelemetryManager to Telemetry via IVT.

By only bumping Trx, the Telemetry package used is 1.5.3, but MTP is 1.6.0. In general, it's a better idea to keep all MTP packages on the same version. So:

    <PackageReference Include="Microsoft.Testing.Extensions.TrxReport" Version="1.6.0" />
    <PackageReference Include="Microsoft.Testing.Extensions.VSTestBridge" Version="1.6.0" />
    <PackageReference Include="Microsoft.Testing.Platform.MSBuild" Version="1.6.0" />

The following shouldn't have issues.

For this specific case, I'm not sure if it's worth fixing, or if we should ask users to not update individual packages without the rest.

[Evangelink]

The "problem" is that NUnit and xUnit current versions are not referencing latest and when people are adding the extension through the NuGet package manager they will install the latest version by default.

I'll take the day to think about what to do here.

cc @MarcoRossignoli

[Youssef1313]

We could detect the MTP version via reflection and access the property with reflection or unsafe accessor when we know the name is different, but it's not ideal.

[Youssef1313]

I think we can also introduce properties with the old names, they will be internal, and we can mark them Obsolete so we don't use them ourselves. But older versions of Telemetry package that are compiled against newer version of MTP can still work because the property exist.

[Evangelink]

I think we can also introduce properties with the old names, they will be internal, and we can mark them Obsolete so we don't use them ourselves. But older versions of Telemetry package that are compiled against newer version of MTP can still work because the property exist.

Yes I think that's the best fix.