Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Looks endless loop #791

Closed
jianwu21 opened this issue Mar 5, 2021 · 3 comments
Closed

Looks endless loop #791

jianwu21 opened this issue Mar 5, 2021 · 3 comments

Comments

@jianwu21
Copy link
Contributor

jianwu21 commented Mar 5, 2021

testfx/src/TestFramework/MSTest.Core/Assertions/StringAssert.cs

Line 580 in 32f53ae

Matches(value, pattern, message);

@jianwu21
Copy link
Contributor Author

jianwu21 commented Mar 5, 2021

This method returns itself, which might cause infinite loops

@nohwnd
Copy link
Member

nohwnd commented Mar 5, 2021

Do you want to PR a fix? It should be quite easy, I think a parameter is just missing to pass this call to another overload.

@jianwu21 jianwu21 mentioned this issue Mar 5, 2021
Merged
@jianwu21
Copy link
Contributor Author

jianwu21 commented Mar 5, 2021

Fixed with #792. @nohwnd

@jianwu21 jianwu21 closed this as completed Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nohwnd @jianwu21