Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run more repos by default, move the NewErrors task earlier. #147

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

DanielRosenwasser
Copy link
Member

This PR should get the Sunday run to:

  1. Run 300 server tests on TS and JS each
  2. Run 800 compiler tests
  3. Run the compiler tests a smidge earlier (I think, someone check my cron)

@@ -10,7 +10,7 @@ parameters:
- name: REPO_COUNT
displayName: Repo Count
type: number
default: 200
default: 300
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is basically always overridden by other workflows, and the triggerer sets this; this probably won't have an effect, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is basically always overridden by other workflows, and the triggerer sets this

I think that the tasks with a schedule that use this template just don't set the REPO_COUNT:

template: azure-pipelines-gitTests-template.yml
parameters:
ENTRYPOINT: tsserver
LANGUAGE: JavaScript

and

https://github.com/microsoft/typescript-error-deltas/blob/main/azure-pipelines-gitTests-tsserver-ts.yml#L17-L20

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, gotcha

@DanielRosenwasser DanielRosenwasser merged commit 92e58b9 into main Mar 20, 2024
2 checks passed
@DanielRosenwasser DanielRosenwasser deleted the moretests branch March 20, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants