Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to consume MGC PR nuget packages from azure-sdk-for-net #4507

Closed
3 tasks done
live1206 opened this issue Sep 24, 2024 · 6 comments
Closed
3 tasks done

Need to consume MGC PR nuget packages from azure-sdk-for-net #4507

live1206 opened this issue Sep 24, 2024 · 6 comments
Assignees
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@live1206
Copy link
Contributor

Clear and concise description of the problem

During the MGC PR, there are NuGet packages generated as artifacts, but they are not published to any feed.
We need to publish them to some internal NuGet feed, so that Azure plugin in azure-sdk-for-net can consume them.

Checklist

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@live1206 live1206 added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Sep 24, 2024
@live1206 live1206 self-assigned this Oct 10, 2024
@live1206
Copy link
Contributor Author

Right now, we have the version tag for NuGet packages as "alpha" and publish them to internal feeds for MGC.
The version tag is based on Prerelease, theoretically we can change the version tag to "dev" if this is a PR trigger.
But then we need to pass along another flag, let's say publish, for the script invoke here.
I think it's not worth to introduce another flag for the script invoke for a temp workaround, since the script is used in a common way.

Ideally, when we start to publish MGC NuGet packages to public feed instead of internal. We can publish NuGet packages to internal feed when it is PR.

@weshaggard Any plan when we will publish to public NuGet feed instead of internal feed for MGC?
cc @m-nash @JoshLove-msft

@weshaggard
Copy link
Member

cc @hallipr who is more in sync with the work happening here.

Is there a reason to publish this package to nuget?

@live1206
Copy link
Contributor Author

live1206 commented Oct 11, 2024

cc @hallipr who is more in sync with the work happening here.

Is there a reason to publish this package to nuget?

@weshaggard @hallipr
Eventually, Microsoft.Generator.CSharp and Microsoft.Generator.CSharp.ClientModel will be available for third-party customers to implement their own generator.
And Azure Plugin consumes it as well for Azure internally.

Right now, we only release NuGet package to internal feed from main branch of this repo. This issue is to figure out a way to release NuGet package to internal feed from PR as well, for integration work in Azure Plugin.
Ideally, we can just release NuGet package to public NuGet from main branch, and release NuGet package to internal NuGet feed for PRs.
That's why I am asking if there is any plan to release it to public NuGet feed from main.

@live1206
Copy link
Contributor Author

I realized we don't need an extra flag for the script, created #4687 to publish NuGet packages with -dev version tag.

But still, ideally we should publish to public NuGet from main branch and to internal feed from PR, like we are doing for npm packages.

@weshaggard
Copy link
Member

I have not see any plans to release the package to nuget.org, if we need that then please work with @hallipr to get that setup. I will add that our dev feed is also publicly available for people to consume from.

@live1206
Copy link
Contributor Author

We decided to manually get the latest version based on branch in https://dev.azure.com/azure-sdk/internal/_build?definitionId=6871&_a=summary
Postpone the public NuGet package release until we need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

No branches or pull requests

2 participants