Treat nonexistent directories as if they are empty. (#191)

Resolves microsoft/vcpkg#19552 and adds a test.
microsoft · Sep 10, 2021 · af08307 · af08307
1 parent b069c9d
commit af08307
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/azure-pipelines/end-to-end-tests-dir/env-tools.ps1 b/azure-pipelines/end-to-end-tests-dir/env-tools.ps1
@@ -0,0 +1,5 @@
+. $PSScriptRoot/../end-to-end-tests-prelude.ps1
+
+$env:VCPKG_DOWNLOADS = Join-Path $TestingRoot 'empty downloads'
+Run-Vcpkg env --bin --tools --python set
+Throw-IfFailed
diff --git a/src/vcpkg/base/files.cpp b/src/vcpkg/base/files.cpp
@@ -1552,7 +1552,11 @@ namespace vcpkg
         {
             std::vector<Path> ret;
             Iter b(to_stdfs_path(dir), ec), e{};
-            if (!ec)
+            if (ec)
+            {
+                translate_not_found_to_success(ec);
+            }
+            else
             {
                 while (b != e)
                 {
@@ -1584,7 +1588,11 @@ namespace vcpkg
         {
             std::vector<Path> ret;
             Iter b(to_stdfs_path(dir), ec), e{};
-            if (!ec)
+            if (ec)
+            {
+                translate_not_found_to_success(ec);
+            }
+            else
             {
                 while (b != e)
                 {
@@ -1630,7 +1638,11 @@ namespace vcpkg
         {
             std::vector<Path> ret;
             Iter b(to_stdfs_path(dir), ec), e{};
-            if (!ec)
+            if (ec)
+            {
+                translate_not_found_to_success(ec);
+            }
+            else
             {
                 while (b != e)
                 {