From fd884a0d390d12783076341bd43d77c3a6a15658 Mon Sep 17 00:00:00 2001 From: Billy Robert O'Neal III Date: Wed, 31 Jul 2024 22:43:10 -0700 Subject: [PATCH] Revert one of the warning skip removals from https://github.com/microsoft/vcpkg-tool/pull/1457 --- cmake/Findfmt.cmake | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cmake/Findfmt.cmake b/cmake/Findfmt.cmake index c1d75825dc..7d8858e786 100644 --- a/cmake/Findfmt.cmake +++ b/cmake/Findfmt.cmake @@ -22,6 +22,9 @@ if(MSVC AND VCPKG_DEVELOPMENT_WARNINGS AND NOT (CMAKE_CXX_COMPILER_ID MATCHES "A set(SKIP_WARNINGS ON) # fmt\base.h(451): warning C6239: ( && ) always evaluates to the result of : Did you intend to use the bitwise-and (`&`) operator? If not, consider removing the redundant '' and the `&&` operator. string(APPEND CMAKE_CXX_FLAGS " /wd6239") + # This one is guarded by an assert + # fmt\format-inl.h(294): warning C6385: Reading invalid data from 'pow10_significands'.: Lines: 265, 267, 294 + string(APPEND CMAKE_CXX_FLAGS " /wd6385") # fmt\os.h(377): warning C6326: Potential comparison of a constant with another constant. string(APPEND CMAKE_CXX_FLAGS " /wd6326") endif()