Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libLAS] improve suggested cmake targets #15908

Closed
grandmaster789 opened this issue Jan 27, 2021 · 1 comment · Fixed by #15750
Closed

[libLAS] improve suggested cmake targets #15908

grandmaster789 opened this issue Jan 27, 2021 · 1 comment · Fixed by #15750
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@grandmaster789
Copy link

grandmaster789 commented Jan 27, 2021


Is your feature request related to a problem? Please describe.
When installing the libLAS package, the following CMake targets are suggested:

    The package liblas:x64-windows provides CMake targets:

        find_package(liblas CONFIG REQUIRED)
        target_link_libraries(main PRIVATE liblas liblas_c)

However when I placed this in a project verbatim, I received a CMake error message:

    Could not find a configuration file for package "liblas" that is compatible with requested version "".
        The following configuration files were considered but not accepted:
        [..........]/share/liblas/liblas-config.cmake, version: 1.8.1 (package = libLAS, NOT liblas)

Proposed solution
The find_package line is case sensitive, so instead of:
find_package(liblas CONFIG REQUIRED)
The correct cmake target that should be suggested is:
find_package(libLAS CONFIG REQUIRED)

Describe alternatives you've considered
Alternatively users could figure this out on their own

@JackBoosY JackBoosY self-assigned this Jan 28, 2021
@JackBoosY
Copy link
Contributor

Confirmed.

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jan 28, 2021
@JackBoosY JackBoosY linked a pull request Jan 28, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants