SPDLOG recent commit is propagating warnings

[prateek9623]

Describe the bug
commit 8a95605 is propagating warning /wd4251 /wd4275 to our CUDA based application. Which doesn't go well with warning flags. Is there anything that can be done about this?

Environment

• OS: Windows
• Compiler: MSVC(14.28.29333), NVCC 11.2

To Reproduce
link with CUDA based application

Expected behavior
the warning should not propagate from spdlog

[NancyLi1013]

Hi @prateek9623

Thanks for posting this issue.

The warning is from upstream, there is no way to solve this. Please see

    if(MSVC)
        target_compile_options(spdlog PUBLIC /wd4251 /wd4275)
    endif()

https://github.com/gabime/spdlog/blob/v1.x/CMakeLists.txt#L134-L136

You can port an issue to upstream if this blocks your application.

[prateek9623]

Hi @prateek9623

Thanks for posting this issue.

The warning is from upstream, there is no way to solve this. Please see

    if(MSVC)
        target_compile_options(spdlog PUBLIC /wd4251 /wd4275)
    endif()

https://github.com/gabime/spdlog/blob/v1.x/CMakeLists.txt#L134-L136

You can port an issue to upstream if this blocks your application.

cant we create a patch to rectify this

[prateek9623]

recent commit in spdlog: gabime/spdlog@8fbc853 fixes this issue

[NancyLi1013]

Thanks for your kindly reminder @prateek9623. I will use the patch to fix it later.