-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tcl] uninstall failure #20546
[tcl] uninstall failure #20546
Comments
|
I think the port installs the files as read only or something like that. |
If we build vcpkg with a recent enough compiler this should be auto-fixed: microsoft/STL#1559 |
But maybe we can disable the read only property, because this also broke our Jenkins pipeline because Jenkins failed to remove the files. |
Actually I observe that we already attempt this: https://github.com/microsoft/vcpkg-tool/blob/2059ef11aa6067e6f59b0d939c5d17e3c5c47d3e/src/vcpkg/base/files.cpp#L1791 so something else is going on. |
The bit on the directory was a red herring, the actual problem is that here we don't clear ec after SetFileAttributes succeeds, so we leave the error in the ec which bubbles up as a failure even though we removed the readonly bit: microsoft/vcpkg-tool#214 is the fix and a test. |
That may also be reasonable, but vcpkg would still need to do the right thing for existing "installed" trees. |
* In filesystem::remove, handle readonly bits correctly on Windows. Resolves microsoft/vcpkg#20546 * Remove useless comment. * fix POSIX * Restrict readonly directory cases to non-POSIX.
Host Environment
To Reproduce
Steps to reproduce the behavior:
vcpkg.json
with dependencytcl
./vcpkg install
vcpkg.json
with dependencyzlib
./vcpkg install
Failure log
The text was updated successfully, but these errors were encountered: