Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot use cjson with cmake #21115

Closed
uri247 opened this issue Nov 1, 2021 · 0 comments · Fixed by #20439
Closed

Cannot use cjson with cmake #21115

uri247 opened this issue Nov 1, 2021 · 0 comments · Fixed by #20439
Assignees
@JonLiu1993
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly

Comments

@uri247
Copy link

uri247 commented Nov 1, 2021

Host Environment

  • OS: Windows
  • Compiler: 16.11

To Reproduce
Steps to reproduce the behavior:
./vcpkg.exe install --triplet=x64-windows-static cjson

After you install, you cannot use the CMake.
The reason is that in line 45 there is:
set(_IMPORT_PREFIX "${_IMPORT_PREFIX}")

This is a regression. It means nothing. Any project that users cjson will fail in line 68 (won't be able to find the cjon.lib).

Should be:
set(_IMPORT_PREFIX "${CMAKE_CURRENT_LIST_DIR}/../..")

As it used to be before
@JonLiu1993 JonLiu1993 self-assigned this Nov 2, 2021
@JackBoosY JackBoosY linked a pull request Nov 2, 2021 that will close this issue
[vcpkg-cmake-config] fix up cmake_current_packages_dir #20439
Merged
@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonLiu1993 JonLiu1993

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vcpkg-cmake-config] fix up cmake_current_packages_dir PhoebeHui/vcpkg
3 participants
@uri247 @JackBoosY @JonLiu1993