[luajit] Build error

[Zyraff]

Package: luajit[core]:x64-windows -> 2023-01-04

Host Environment

• Host: x64-windows
• Compiler: MSVC 19.35.32216.1
• vcpkg-tool version: 2023-03-14-105f7f7e8a5ea10dfac9874ff9d1a6bacba5f454
  vcpkg-scripts version: 1271068 2023-03-28 (16 hours ago)

To Reproduce

vcpkg install luajit:x64-windows

Failure logs

-- Using cached LuaJIT-LuaJIT-d0e88930ddde28ff662503f9f20facf34f7265aa.tar.gz.
-- Cleaning sources at E:/Repo/vcpkg/buildtrees/luajit/src/f34f7265aa-d28f2f5801.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source E:/Repo/vcpkg/downloads/LuaJIT-LuaJIT-d0e88930ddde28ff662503f9f20facf34f7265aa.tar.gz
-- Applying patch 003-do-not-set-macosx-deployment-target.patch
-- Applying patch 004-fix-build-path-and-crt-linkage.patch
-- Using source at E:/Repo/vcpkg/buildtrees/luajit/src/f34f7265aa-d28f2f5801.clean
-- Building x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process_repeat.cmake:65 (message):
    Command failed: "E:/Repo/vcpkg/buildtrees/luajit/src/f34f7265aa-d28f2f5801.clean/src/msvcbuild.bat" "E:/Repo/vcpkg/buildtrees/luajit/src/f34f7265aa-d28f2f5801.clean/src" dynamic debug
    Working Directory: E:/Repo/vcpkg/buildtrees/luajit/x64-windows-dbg
    See logs for more information:
      E:\Repo\vcpkg\buildtrees\luajit\build-x64-windows-dbg-out-1.log
      E:\Repo\vcpkg\buildtrees\luajit\build-x64-windows-dbg-out-1.log

Call Stack (most recent call first):
  ports/luajit/portfile.cmake:43 (vcpkg_execute_required_process_repeat)
  scripts/ports.cmake:147 (include)

Additional context
build-x64-windows-dbg-out-1.log

[dg0yt]

vcpkg/ports/luajit/004-fix-build-path-and-crt-linkage.patch

Line 41 in 1271068

@if "%1" neq "nogc64" goto :GC64

This (upstream) line and similar ones may need to be patched to use "%~1" instead of "%1" in order to remove quotes in incoming arguments.

[FrankXie05]

This is an upstream bug, and I will report it to the upstream and submit a PR .

[dg0yt]

Does the error really occur for a regular working dir? It doesn't fail in vcpkg CI.

FTR the initial post used a working direcory with space in working dir:

-- Cleaning sources at E:/OTS Repo/vcpkg/buildtrees/luajit/src/f34f7265aa-d28f2f5801.clean. Use --editable to skip cleaning for the packages you specify.

In this case, quotes are necessary to pass parameters,

[Zyraff]

Sorry for the confusion, original working directory indeed contains a space and after changing it, it worked.
before: E:/OTS Repo/vcpkg
after: E:/Repo/vcpkg

[FrankXie05]

The path parameter should not have been passed. Draft my PR, and waiting for Upstream repair.
LuaJIT/LuaJIT#976 (comment)

[dg0yt]

This first parameter is from the massive vcpkg patch for out-of-source builds.
This should be revised to be less invasive. Use shift, or use %4, or simply avoid patching and copy the source instead.

[dg0yt]

#30608 is ready for testing. It removed the pattern which caused this issue, but I did not check if other spots continue to block paths with spaces.

[github-actions]

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

[FrankXie05]

Has been fixed by PR #30608