Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wxwidgets] Add possibility to use wxSecretStore #39588

Closed
reind33r opened this issue Jun 28, 2024 · 0 comments · Fixed by #39616
Closed

[wxwidgets] Add possibility to use wxSecretStore #39588

reind33r opened this issue Jun 28, 2024 · 0 comments · Fixed by #39616
Assignees
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@reind33r
Copy link

reind33r commented Jun 28, 2024

Is your feature request related to a problem? Please describe.

It is not possible to use wxSecretStore, to use the system credentials manager to save secrets, because it is disabled during wxWidgets compilation.

Proposed solution

Not sure about the implications; it was disabled to "avoid introduce system pcre in wx-config", according to the commit where it was introduced.

Describe alternatives you've considered

I tried to override wxUSE_SECRETSTORE using a custom triplet, but my knowledge of vcpkg is still limited, I am just migrating from manually compiling the libraries.

Conditionally disabling the secret store in my code is an option; but it is a nice functionnality to offer users to save their credentials to avoid typing them every time.

Additional context

In [ports/wxwidgets/portfile.cmake, wxUSE_SECRETSTORE=FALSE (to "avoid introduce system pcre in wx-config", according to the commit where it was introduced: 20907dc)

@reind33r reind33r added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants