Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzer assemblies must have a new version with each release #279

Closed
sharwell opened this issue May 13, 2018 · 2 comments
Closed

Analyzer assemblies must have a new version with each release #279

sharwell opened this issue May 13, 2018 · 2 comments
Assignees
@AArnott
Labels
analyzers
Milestone
v15.7

Comments

@sharwell
Copy link
Member

sharwell commented May 13, 2018 •
edited
Loading

Bug description

Currently the analyzers assembly is using a versioning policy where the AssemblyVersion is set to major.minor.0.0. This versioning policy makes it impossible for the build to ensure the correct version of this assembly is used in builds involving mixed version references. Every release of an analyzer assembly must increment the version relative to all previous versions to ensure this does not occur.

📝 This only applies to analyzer assemblies, and not to the main library.
@AArnott
Copy link
Member

AArnott commented May 13, 2018

This has bitten me several times lately as well, and I have to restart VS to get the new analyzers running after an update. We can fix this.

@AArnott AArnott self-assigned this May 13, 2018
@AArnott AArnott added this to the v15.8 milestone May 13, 2018
@AArnott AArnott mentioned this issue May 13, 2018
Merged
@AArnott AArnott modified the milestones: v15.8, v15.7 May 13, 2018
@sharwell sharwell mentioned this issue May 14, 2018
Closed
sharwell added a commit to sharwell/DocumentationAnalyzers that referenced this issue Sep 18, 2018
@sharwell
Use precise assembly versions
51dd2db 
See microsoft/vs-threading#279
@Dreamescaper Dreamescaper mentioned this issue May 22, 2019
Closed
@AArnott
Copy link
Member

AArnott commented Sep 10, 2020

Note this wasn't entirely fixed in #281. A follow up fix was required: a152779

@sharwell sharwell mentioned this issue Aug 27, 2021
Closed
AArnott pushed a commit that referenced this issue Aug 27, 2024
@dependabot
Bump nbgv from 3.6.139 to 3.6.141 (#279)
90af89a 
Bumps [nbgv](https://github.com/dotnet/Nerdbank.GitVersioning) from 3.6.139 to 3.6.141.
- [Release notes](https://github.com/dotnet/Nerdbank.GitVersioning/releases)
- [Commits](dotnet/Nerdbank.GitVersioning@v3.6.139...v3.6.141)

---
updated-dependencies:
- dependency-name: nbgv
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@AArnott AArnott mentioned this issue Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
analyzers
Projects
None yet
Milestone
v15.7
Development

No branches or pull requests
2 participants
@AArnott @sharwell