format on save formats stdlib code

[DetachHead]

sometimes i accidentally make changes to stdlib files (eg. [python install directory]/lib/typing.py) and typeshed files (eg. %userprofile%/.vscode/extensions/ms-python.vscode-pylance-2023.6.10/dist/typeshed-fallback/stdlib), and it's annoying when they get formatted by this extension

[karthiknadig]

@DetachHead Can you try with the pre-release version? I recently updated the stdlib check, and this is in pre-release

[DetachHead]

it now correctly ignores stdlib files but still formats typeshed files (located in %userprofile%/.vscode/extensions/ms-python.vscode-pylance-2023.6.10/dist/typeshed-fallback/stdlib)

[pkgw]

I believe that the fix for this issue is causing a different problem. For me, this extension is now failing to format many of my files because I have installed them in development mode with pip install -e. This appears to put them in the extension's idea of what the system path is:

2023-07-11 23:14:13.878 [info] sys.path used to run Server:
   /home/peter/.vscode/extensions/ms-python.black-formatter-2023.4.1/bundled/libs
   /home/peter/.vscode/extensions/ms-python.black-formatter-2023.4.1/bundled/tool
   /a/lib/python39.zip  # <-- my default Python environment
   /a/lib/python3.9
   /a/lib/python3.9/lib-dynload
   /a/lib/python3.9/site-packages
   [...]
   /a/wwt/sw/toasty   # <-- a Git development checkout 
   /a/dasch/sw/daschdata  # <-- ditto

Which then means that the files simply don't get formatted:

2023-07-11 23:14:40.610 [info] [Warn  - 11:14:40 PM] Skipping standard library file: /a/dasch/sw/daschdata/daschdata/treecli.py

This is a severe problem for me since, by definition, the trees affected by this are the ones that I'm editing in VS Code!

[karthiknadig]

@pkgw Can you give me the output of this for your environment?

import sysconfig 
print(sysconfig.get_paths())

[pkgw]

For my default interpreter, it's:

{
  'stdlib': '/a/lib/python3.9', 
  'platstdlib': '/a/lib/python3.9', 
  'purelib': '/a/lib/python3.9/site-packages', 
  'platlib': '/a/lib/python3.9/site-packages', 
  'include': '/a/include/python3.9', 
  'platinclude': '/a/include/python3.9', 
  'scripts': '/a/bin', 
  'data': '/a'
}

I should also mention that this problem has actually been affecting me for the past few releases; the changes introduced for this specific issue don't seem to be specifically relevant to what I'm seeing. I can file a separate issue if that would be better.

[karthiknadig]

@pkgw There is a specific issue for this now: #272

@DetachHead would you be a to provide the same info for your case?

import sysconfig 
print(sysconfig.get_paths())

Basically, there are two options:

1. [Option 1] : If there is a clear way to separate editable installs from other paths then we can use that to safely categorize stdlib vs user files. Downside, if someone really wants to format stdlib files this still blocks them. It is also possible that our guess can be wrong.
2. [Option 2] : A (boolean) Setting to override stdlib filter entirely.

[karthiknadig]

Can you try 2023.5.11941908 version to see if it helps?

[itsbjoern]

That did fix it for me, thank you :)