This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
Fix breakpoint not hitting in refresh because it's being set on a negative line #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the problem exactly and why does this fix it? It sounds like you're describing the problem that this was originally added to fix, but I can't repro any issue now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breakpoints weren't being hit after refresh because BreakOnLoadHelper.resolvePendingBreakpoints was passing a value from inside this._chromeDebugAdapter.pendingBreakpointsByUrl to chromeDebugAdapter.setBreakpoints, and setBreakpoints was calling LineColTransformer and substracting 1 to the line number again.
The deep copy on args prevents setBreakpoints from modifying the original args...