Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

Stacktrace test improvements #840

Merged
merged 5 commits into from
May 23, 2019
Merged

Stacktrace test improvements #840

merged 5 commits into from
May 23, 2019

Conversation

mrcrane
Copy link
Contributor

@mrcrane mrcrane commented May 17, 2019

  • Refactor stacktrace tests to use the common breakpoints wizard code
  • Update stacktrace tests to cover eval code test case
  • Update stacktrace tests to use chai expect

digeff
digeff suggested changes May 17, 2019
View reviewed changes
Copy link
Contributor

@digeff digeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design looks good :)

test/int/stackTrace.test.ts Outdated Show resolved Hide resolved
test/int/wizards/breakpoints/implementation/internalFileBreakpointsWizard.ts Show resolved Hide resolved
test/int/stackTrace.test.ts Outdated Show resolved Hide resolved
test/int/wizards/breakpoints/implementation/breakpointsAssertions.ts Outdated Show resolved Hide resolved
test/int/wizards/breakpoints/implementation/breakpointsAssertions.ts Outdated Show resolved Hide resolved
test/int/stackTrace.test.ts Outdated Show resolved Hide resolved
@mrcrane mrcrane force-pushed the stacktrace-test-improvements branch from 576aabc to 0e3916e Compare May 21, 2019 17:18
@mrcrane mrcrane force-pushed the stacktrace-test-improvements branch from b831d75 to dd23fe9 Compare May 22, 2019 19:12
@roblourens roblourens merged commit 9abf187 into microsoft:v2 May 23, 2019
@sirinartk sirinartk mentioned this pull request Nov 4, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 25, 2022
Open
@sirinartk sirinartk mentioned this pull request Nov 28, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens left review comments

@digeff digeff digeff approved these changes

Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrcrane @roblourens @digeff