Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ctrl + Click Go to definition for functions and macros #1634

Closed
gudnimg opened this issue Jan 27, 2021 · 7 comments
Closed
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: language services help wanted we currently are not planning work on this and would like help from the open source community stale-old to use with the close-old-issues bot
Milestone

Comments

@gudnimg
Copy link

gudnimg commented Jan 27, 2021

When I define a function or macro in .cmake or CMakeLists.txt file I cannot use CTRL + Left Click to see the function definition. I am specifically thinking of this: https://code.visualstudio.com/docs/editor/editingevolved#_go-to-definition

I didn't find a similar issue for this.

Platform and Versions

  • Operating System: Windows
  • CMake Version: 3.19.3
  • VSCode Version: 1.52.1
  • CMake Tools Extension Version: 1.5.3
  • Compiler/Toolchain: GCC for x86_64-linux-gnu 9.3.0

Other Notes/Information

I am using WSL on Windows. (Ubuntu 20.04)

@andreeis
Copy link
Contributor

Thank you for this feature request. Currently, language service features for the CMake language are not on our road map.
We will gladly accept help from the community for this.
Here's a similar GitHub report that is also about CMake langauge services: #534.
You can also check out https://marketplace.visualstudio.com/items?itemName=twxs.cmake.

@andreeis andreeis added Feature: language services help wanted we currently are not planning work on this and would like help from the open source community labels Jan 27, 2021
@andreeis andreeis added this to the Backlog milestone Jan 27, 2021
@andreeis andreeis added the enhancement an enhancement to the product that is either not present or an improvement to an existing feature label Jan 27, 2021
@gudnimg
Copy link
Author

gudnimg commented Jan 27, 2021

Thanks for the reply, I have twxs.cmake installed and it doesn't support this either. https://github.com/twxs/vs.language.cmake the repo hasn't been updated in 15 months and has numerous syntax highlighting issues.

@andreeis
Copy link
Contributor

I understand. I hope we'll have resources to address this scenario as well at some point. Until then, maybe someone in the community will step up.

@Zingam
Copy link
Contributor

Zingam commented Feb 1, 2021

@andreeis Do you have any plans to integrate twxs functionality in this extension?
I think that having everything under a single umbrella makes sense now.

@andreeis
Copy link
Contributor

andreeis commented Feb 3, 2021

Integration not yet, but we are currently testing a change that would cause the twxs extension to be recommended by VSCode when opening CMake projects, same way CMake Tools is recommended.

@github-actions
Copy link

This issue is now marked as 'stale-old' due to there being no activity on it for the past 720 days. Unless the 'stale-old' label is removed or the issue is commented on, this will be remain open for at least 14 days and then it may be closed. If you would like to make this issue exempt from getting stale, please add the 'stale-exempt' label.

@github-actions github-actions bot added the stale-old to use with the close-old-issues bot label Oct 19, 2023
@benmcmorran
Copy link
Member

Closing as covered by #93 which is on our upcoming roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: language services help wanted we currently are not planning work on this and would like help from the open source community stale-old to use with the close-old-issues bot
Projects
None yet
Development

No branches or pull requests

4 participants