Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancements on "Install" and "clean" task when using presets #2706

Closed
elahehrashedi opened this issue Aug 24, 2022 · 0 comments
Closed

enhancements on "Install" and "clean" task when using presets #2706

elahehrashedi opened this issue Aug 24, 2022 · 0 comments
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: tasks
Milestone

Comments

@elahehrashedi
Copy link
Contributor

elahehrashedi commented Aug 24, 2022

Currently, install and clean tasks when using presets, are operating on the active preset.

There needs to be an entry in these tasks to target a specific build.
@sinemakinci1 @bobbrow , Both install and clean are a specific kind of build. Does it make sense to let them use the build preset name?
e.g.:

		{
			"type": "cmake",
			"label": "CMake: clean",
			"command": "clean",
			"preset": "${command:cmake.activeBuildPresetName}",
			"detail": "CMake template clean task"
		}
@elahehrashedi elahehrashedi added enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: tasks labels Aug 24, 2022
@elahehrashedi elahehrashedi added this to the On Deck milestone Aug 24, 2022
@elahehrashedi elahehrashedi modified the milestones: On Deck, 1.12 Aug 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: tasks
Projects
None yet
Development

No branches or pull requests

1 participant